Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate js & css from layout to web/static #80

Open
erickhsiao opened this issue May 19, 2016 · 2 comments
Open

Separate js & css from layout to web/static #80

erickhsiao opened this issue May 19, 2016 · 2 comments

Comments

@erickhsiao
Copy link

I am integrate addict to my existing project and figure out authorization isn't trigger by form action but js.
I can simply copy & paste those css & js to my existing file, or change js to form action, but still, I think move those code into separate file under static web is more appropriate.

@trenpixster
Copy link
Owner

@erickhsiao that was my initial approach, but it gave several issues when using a deployment strategy based on assets compilation or when external tooling (think react) would be used. That said, if you have any idea for a better approach I'm all ears! 😄

@erickhsiao
Copy link
Author

Probably need to get better and better rather than get to the goal at first time.
By that, React should be another issue we don't need to consider right now.

Providing stand alone files will fit most scenario, most framework can load & play nice with them.
By compilation, we can just follow phoenix native compilation method which is brunch.js or run node command directly to compile assets into priv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants