Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL parsing implemented, plus minor fixes in some related files #623

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

MySQL parsing implemented, plus minor fixes in some related files #623

wants to merge 8 commits into from

Conversation

jnichols-git
Copy link
Member

Signed-off-by: jakenichols2719 jnichols2719@protonmail.com

@jnichols-git
MySQL parsing implemented, plus minor fixes in some related files
f1b762f 
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@jnichols-git jnichols-git requested a review from jranson December 4, 2022 22:14
@jnichols-git jnichols-git linked an issue Dec 5, 2022 that may be closed by this pull request
MySQL Support for Trickster : Please #602
Open
jranson and others added 7 commits January 22, 2023 11:11
@jranson
fix codespell typo
d71a611 
Signed-off-by: James Ranson <james@ranson.org>
@jranson
fix failing tests
17c4967 
Signed-off-by: James Ranson <james@ranson.org>
@jranson
s/clickhouse/MySQL/gi
183e24f 
Signed-off-by: James Ranson <james@ranson.org>
@jnichols-git
Intepret timeseries column division as step, test more queries
ea0bdb2 
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@jnichols-git
Merge remote-tracking branch 'upstream/main' into mysql
cdcbd09
@jnichols-git
Handle aggregate functions on tscol
cd46f47 
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@jnichols-git
Add SetExtent for mysql client
8eff719 
Signed-off-by: jakenichols2719 <jnichols2719@protonmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5136622783

  • 697 of 832 (83.77%) changed or added relevant lines in 13 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 92.361%
Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/trickster/main.go 1 3 33.33%
pkg/backends/mysql/url.go 13 15 86.67%
pkg/backends/mysql/mysql.go 45 49 91.84%
cmd/trickster/listeners.go 3 12 25.0%
pkg/backends/mysql/model/datatypes.go 0 9 0.0%
pkg/backends/mysql/handler_query.go 12 28 42.86%
pkg/backends/mysql/parsing.go 194 240 80.83%
pkg/backends/mysql/model/model.go 379 426 88.97%
Files with Coverage Reduction New Missed Lines %
pkg/cache/bbolt/bbolt.go 4 88.55%
Totals Coverage Status
Change from base Build 5008571097: -0.4%
Covered Lines: 17870
Relevant Lines: 19348
💛 - Coveralls

@jnichols-git jnichols-git marked this pull request as ready for review May 31, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jranson jranson Awaiting requested review from jranson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MySQL Support for Trickster : Please
3 participants
@jnichols-git @coveralls @jranson