From 8d18e6eceaa4465ba6d7710d995e26353cd0e83f Mon Sep 17 00:00:00 2001 From: Benjamin Bischoff Date: Tue, 8 May 2018 11:04:07 +0200 Subject: [PATCH] added fix for source feature file path comments --- CHANGELOG.md | 5 +++++ example-project/pom.xml | 2 +- plugin-code/pom.xml | 2 +- .../com/trivago/rta/runners/RunnerFileContentRenderer.java | 2 +- .../trivago/rta/runners/RunnerFileContentRendererTest.java | 4 ++-- 5 files changed, 10 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 337b180..dde0885 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. Back to [Readme](README.md). +## [0.1.11] - 2018-05-08 + +- Fix for wrong unicode detection of source feature path in runner comments + ## [0.1.10] - 2018-05-08 - Runner comments containing "\u" were wrongly considered unicode @@ -135,6 +139,7 @@ Back to [Readme](README.md). Initial project version on GitHub and Maven Central. +[0.1.11]: https://github.com/trivago/cucable-plugin/compare/0.1.10...0.1.11 [0.1.10]: https://github.com/trivago/cucable-plugin/compare/0.1.9...0.1.10 [0.1.9]: https://github.com/trivago/cucable-plugin/compare/0.1.8...0.1.9 [0.1.8]: https://github.com/trivago/cucable-plugin/compare/0.1.7...0.1.8 diff --git a/example-project/pom.xml b/example-project/pom.xml index ca10494..623bfc0 100644 --- a/example-project/pom.xml +++ b/example-project/pom.xml @@ -6,7 +6,7 @@ de.benjamin-bischoff cucable-test-project - 0.1.10 + 0.1.11 UTF-8 diff --git a/plugin-code/pom.xml b/plugin-code/pom.xml index ae97890..0644d38 100644 --- a/plugin-code/pom.xml +++ b/plugin-code/pom.xml @@ -6,7 +6,7 @@ com.trivago.rta cucable-plugin - 0.1.10 + 0.1.11 https://github.com/trivago/cucable-plugin Cucable Maven Plugin diff --git a/plugin-code/src/main/java/com/trivago/rta/runners/RunnerFileContentRenderer.java b/plugin-code/src/main/java/com/trivago/rta/runners/RunnerFileContentRenderer.java index 6efd1f0..f356ddd 100644 --- a/plugin-code/src/main/java/com/trivago/rta/runners/RunnerFileContentRenderer.java +++ b/plugin-code/src/main/java/com/trivago/rta/runners/RunnerFileContentRenderer.java @@ -97,7 +97,7 @@ private String addScenarioInfo( .concat(System.lineSeparator()) .concat(System.lineSeparator()) .concat("// Source Feature: ") - .concat(singleScenario.getFeatureFilePath()) + .concat(singleScenario.getFeatureFilePath().replace("\\", "/")) .concat(System.lineSeparator()) .concat("// Generated by Cucable from ") .concat(runnerTemplatePath.replace("\\", "/")) diff --git a/plugin-code/src/test/java/com/trivago/rta/runners/RunnerFileContentRendererTest.java b/plugin-code/src/test/java/com/trivago/rta/runners/RunnerFileContentRendererTest.java index 84008cd..e1fae21 100644 --- a/plugin-code/src/test/java/com/trivago/rta/runners/RunnerFileContentRendererTest.java +++ b/plugin-code/src/test/java/com/trivago/rta/runners/RunnerFileContentRendererTest.java @@ -89,7 +89,7 @@ public void getRenderedFeatureFileContentReplaceBackslashInCommentTest() throws "}\n" + "\n" + "\n" + - "// Source Feature: \n" + + "// Source Feature: c:/unknown/path2\n" + "// Generated by Cucable from c:/unknown/path\n"; SingleScenarioRunner singleScenarioRunner = new SingleScenarioRunner( @@ -97,7 +97,7 @@ public void getRenderedFeatureFileContentReplaceBackslashInCommentTest() throws "featureFileName" ); - SingleScenario singleScenario = new SingleScenario("", "", "", "", "", "", null, null); + SingleScenario singleScenario = new SingleScenario("", "c:\\unknown\\path2", "", "", "", "", null, null); String renderedRunnerFileContent = runnerFileContentRenderer.getRenderedRunnerFileContent(singleScenarioRunner, singleScenario); assertThat(renderedRunnerFileContent, is(expectedOutput));