From 2a4967e5b851f8c57c582a6b95c57debbd004521 Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Sat, 6 Jul 2024 19:44:48 +0200 Subject: [PATCH 1/4] Remove unused rubocop-rspec_rails dependency This dependency was added to pin rubocop-rspec_rails, a dependency of rubocop-rspec, to a known good version and thus avoid an error. Since rubocop-rspec no longer depends on rubocop-rspec_rails, and Reek development does not use this plugin, the dependency can now be removed. --- Gemfile | 1 - 1 file changed, 1 deletion(-) diff --git a/Gemfile b/Gemfile index b5986e4fe..ac2622afe 100644 --- a/Gemfile +++ b/Gemfile @@ -17,7 +17,6 @@ group :development do gem 'rubocop', '~> 1.64.1' gem 'rubocop-performance', '~> 1.21.0' gem 'rubocop-rspec', '~> 3.0.2' - gem 'rubocop-rspec_rails', '~> 2.29.0' gem 'simplecov', '>= 0.18.0', '< 0.23.0' gem 'yard', '~> 0.9.5' From 3fe6dd6957e2b245cf8164b5d40bd71760494c54 Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Sat, 6 Jul 2024 19:46:11 +0200 Subject: [PATCH 2/4] Require latest simplecov version Simplecov 0.22.0 supports all of the Ruby versions that Reek supports, so there is no need to allow older simplecov versions. --- Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index ac2622afe..b48b1a4c8 100644 --- a/Gemfile +++ b/Gemfile @@ -17,7 +17,7 @@ group :development do gem 'rubocop', '~> 1.64.1' gem 'rubocop-performance', '~> 1.21.0' gem 'rubocop-rspec', '~> 3.0.2' - gem 'simplecov', '>= 0.18.0', '< 0.23.0' + gem 'simplecov', '~> 0.22.0' gem 'yard', '~> 0.9.5' platforms :mri do From 68086af03f2d30feb8584243b6e85d083fcd21e9 Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Sat, 6 Jul 2024 20:56:32 +0200 Subject: [PATCH 3/4] Remove development dependency on bigdecimal This dependency was added due to warnings that it was used by gems Reek depends on. Those gems have now added bigdecimal as a direct dependency. Therefore, this extra development dependency is no longer needed and can be removed. --- Gemfile | 1 - 1 file changed, 1 deletion(-) diff --git a/Gemfile b/Gemfile index b48b1a4c8..9b3df25a3 100644 --- a/Gemfile +++ b/Gemfile @@ -6,7 +6,6 @@ ruby RUBY_VERSION group :development do gem 'aruba', '~> 2.1' - gem 'bigdecimal', '>= 2.0.0', '< 4.0' gem 'codeclimate-engine-rb', '~> 0.4.0' gem 'cucumber', '~> 9.0' gem 'kramdown', '~> 2.1' From 60b7f50a7e794d937a5fae105f5578da35214828 Mon Sep 17 00:00:00 2001 From: Matijs van Zuijlen Date: Sun, 7 Jul 2024 10:36:57 +0200 Subject: [PATCH 4/4] Explain the need for redcarpet The development dependencies include both kramdown and redcarpet. Kramdown is used in the code, but we need redcarpet for nice YARD output. --- Gemfile | 1 + 1 file changed, 1 insertion(+) diff --git a/Gemfile b/Gemfile index 9b3df25a3..feb3b137c 100644 --- a/Gemfile +++ b/Gemfile @@ -20,6 +20,7 @@ group :development do gem 'yard', '~> 0.9.5' platforms :mri do + # Needed for YARD to properly parse GFM code blocks in the documentation gem 'redcarpet', '~> 3.4' end end