Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JDK 17 for ARM Architecture #5976

Open
halibobo1205 opened this issue Aug 28, 2024 · 15 comments
Open

Upgrade to JDK 17 for ARM Architecture #5976

halibobo1205 opened this issue Aug 28, 2024 · 15 comments

Comments

@halibobo1205
Copy link
Contributor

Background

Java-Tron currently only supports Oracle JDK 8. However, despite the wide usage of JDK 8, it is no longer the most preferable option for development for multiple reasons and limitations. For instance, the End of Public Updates process for legacy releases and the End of Commercial Use under the Oracle Technology Network License Agreement for Java SE both hold that. On the contrary, JDK 17 is the LTS (Long Term Support) version of Oracle announced for free commercial use in 2021. It has significant improvements in performance, stability, and security, with advantages as follows:

Caution

Oracle JDK Development Kit 17.0.12 is the last planned update of JDK 17 under the NFTC. Updates after September 2024 will be licensed under the Java SE OTN License (OTN) and production use beyond the limited free grants of the OTN license will require a fee. I suggest moving to OpenJDK 17, see more distributions.

  • LTS: Long-Term-Support, Premier Support Until September 2026 or later.
  • AArch64 Port
  • Garbage Collectors
  • Language

Related Issues and PRs

Scope of Impact

  • Build and deployment processes
  • Core application codes
  • Third-party dependencies
  • Development and testing environments
@CarlChaoCarl
Copy link
Contributor

@halibobo1205

As far as I know
For besu, Java 21 or later is required to build Besu
Will java-tron limit the java version, or is it still compatible with java8

@tronprotocol tronprotocol deleted a comment Aug 28, 2024
@abn2357
Copy link

abn2357 commented Aug 28, 2024

When do you plan to begin this upgrade?JDK 8 is unable to keep up with the times.

@thuthu24
Copy link

Background

Java-Tron currently only supports Oracle JDK 8. However, despite the wide usage of JDK 8, it is no longer the most preferable option for development for multiple reasons and limitations. For instance, the End of Public Updates process for legacy releases and the End of Commercial Use under the Oracle Technology Network License Agreement for Java SE both hold that. On the contrary, JDK 17 is the LTS (Long Term Support) version of Oracle announced for free commercial use in 2021. It has significant improvements in performance, stability, and security, with advantages as follows:

[!CAUTION]
Oracle JDK Development Kit 17.0.12 is the last planned update of JDK 17 under the NFTC. Updates after September 2024 will be licensed under the Java SE OTN License (OTN) and production use beyond the limited free grants of the OTN license will require a fee. I suggest moving to OpenJDK 17, see more distributions.

  • LTS: Long-Term-Support, Premier Support Until September 2026 or later.
  • AArch64 Port

[!IMPORTANT]

  • Garbage Collectors

[!IMPORTANT]

  • Language

[!IMPORTANT]

Related Issues and PRs

Scope of Impact

  • Build and deployment processes
  • Core application codes
  • Third-party dependencies
  • Development and testing environments

@halibobo1205
Copy link
Contributor Author

Java 21 or later is required to build

@CarlChaoCarl Java 17 or later is required to build Java-Tron.

@halibobo1205
Copy link
Contributor Author

When do you plan to begin this upgrade?JDK 8 is unable to keep up with the times.

@abn2357 The current phase is under discussion, and the evaluation will be based on the workload.

@halibobo1205
Copy link
Contributor Author

Try to work with both JDK8 and JDK17.

@halibobo1205
Copy link
Contributor Author

halibobo1205 commented Sep 3, 2024

Here are some common considerations:

Caution

  1. Floating-point arithmetic
    Jdk17 may have subtle differences in floating-point precision and behavior.
    Comprehensive testing is necessary for applications that rely on precise floating-point calculations.

Important

2. Default Behavior Changes

Important

3. JVM options Changes

  • log JVM options
  • Garbage options
  • ... ...

Important

4. Third-party dependencies
Ensure all third-party libraries and dependencies support JDK17.
Some incompatible dependencies may need to be updated or replaced.

  • springframework
  • lombok
  • javax
  • mockito
  • ... ...

Important

5. Gradle plugins
Ensure all Gradle plugins support JDK17.
Some incompatible plugins may need to be updated or replaced.

  • jacoco
  • checkstyle
  • ... ...

Important

6. Build and deployment process:

  • Update build scripts to support JDK17.
  • Ensure CI/CD pipelines can be built and tested in JDK17 environments.
  • Docker support

Important

7. Cross-JDK testing

  • Establish comprehensive test suites to ensure the functionality works correctly on JDK.
  • Conduct performance benchmarking to compare JKD8 and JDK17 performance differences.

@Murphytron
Copy link

This issue has been added to the core devs community call #23, welcome to share the latest progress @halibobo1205, and discuss together with @CarlChaoCarl @abn2357 @thuthu24.

@halibobo1205
Copy link
Contributor Author

Caution

8. Strong data consistency and finality
Final data consistency is required for blockchain, and the world state usually guarantees it. Unfortunately, Java-Tron doesn't have a world state.
We need to think about how to ensure final data consistency.

@halibobo1205
Copy link
Contributor Author

Caution

  1. Floating-point arithmetic
    Jdk17 may have subtle differences in floating-point precision and behavior.
    Comprehensive testing is necessary for applications that rely on precise floating-point calculations.

@halibobo1205
Copy link
Contributor Author

Important

Commercial Use
under the Java SE OTN License (OTN), only free for:
( i) Personal Use,
(ii) Development Use,
(iii) Oracle Approved Product Use, and/or
(iv) Oracle Cloud Infrastructure Use.

Tron's other behavior should be identified as Commercial Use.

@halibobo1205
Copy link
Contributor Author

Important

JDK version compatibility

  • Java 17 or later is required to build Java-Tron?
  • Compatible with JDK8 and JDK17+?

@halibobo1205
Copy link
Contributor Author

Important

JDK provider

  • Oracle JDK?
  • Open JDK?

@halibobo1205
Copy link
Contributor Author

halibobo1205 commented Oct 22, 2024

We'll be doing most of the compatibility upgrades in 4.8.1

@halibobo1205
Copy link
Contributor Author

halibobo1205 commented Oct 25, 2024

  1. Historical Compatibility Considerations

    • All existing java-tron deployment base on x86 architecture, direct upgrade to JDK17 would affect currently stable running nodes.
    • Maintaining JDK8 on x86 ensures smooth operation of existing nodes, avoiding risks from forced upgrades
  2. ARM Architecture Advantages

    • ARM is a new deployment without historical baggage.
    • JDK17 has better performance optimization on ARM architecture.
    • ARM architecture has higher power efficiency, new JDK version can fully leverage these advantages.
  3. Technical Evolution Path

    • This dual-track approach allows experimenting with JDK17 on ARM platform first.
    • Can accumulate experience through ARM + JDK17 practice.
    • Provides reference for future x86 platform upgrade to JDK17.
  4. Risk Control

    • Limiting changes to new platform (ARM) reduces impact on existing systems.
    • If ARM + JDK17 encounters issues, it won't affect main x86 nodes.
    • Phased approach makes risk control easier.
  5. Resource Investment Considerations

    • Avoids handling both architecture migration and JDK upgrade simultaneously.
    • Can focus resources on ensuring smooth ARM platform support.
    • Accumulates experience and best practices for subsequent x86 upgrades.
  6. Operational Complexity

    • Maintaining JDK8 on x86 platform temporarily reduces operational pressure.
    • ARM platform as new deployment allows ops team to plan best practices from scratch.
  7. Performance Validation

    • Can conduct thorough performance testing in ARM + JDK17 environment.
    • Collect actual running data to inform future x86 upgrade decisions.

This strategy ensures both the stability of existing systems and explores paths for future technical upgrades, making it a practical solution. It's recommended to plan the x86 platform JDK upgrade timeline after gaining successful experience on the ARM platform.

Based on the above considerations, JDK17 is supported on ARM, x86 is not upgraded to JDK17 for the time being.
Any suggestions are always welcome!

@halibobo1205 halibobo1205 changed the title Upgrade to JDK 17 Upgrade to JDK 17 for ARM Architecture Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants
@halibobo1205 @CarlChaoCarl @Murphytron @abn2357 @thuthu24 and others