Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] Add an option in search to disable results previewing. #38

Open
Haralil opened this issue May 6, 2022 · 5 comments · May be fixed by #39
Open

[Suggestion] Add an option in search to disable results previewing. #38

Haralil opened this issue May 6, 2022 · 5 comments · May be fixed by #39

Comments

@Haralil
Copy link

Haralil commented May 6, 2022

Hello.
I recently discovered a problem with my modded world and had to remove a lot of data from region files due to some errors. Each region file in my world has around 6 thousands of bad entries, and opening every NBT tree in NBT Studio takes a really long time. Moreover, when I am deleting the entries, it has to redraw everything again, and I had to waste ~10 hours until I found out that you can just close the trees and do the deletion. Instead of taking 10 minutes for a deletion per file, it now took seconds.
Can you please add a setting so that previewing found entries can be disabled? That would really help when working with large data set with a lot of entries, like world regions.
Thanks.
@tryashtar
Copy link
Owner

I'm really sorry for the bad performance. Can you show me which preview you're referring to?

@Haralil
Copy link
Author

Haralil commented May 6, 2022 •
edited
Loading

Yes, sure thing. I am currently editing my world, and when the search finishes, it opens every tree.
image
If, instead, after searching, just as shown in the 2nd picture, it would not open every tree with found results, that would improve the speed drastically.
image

Edit: I think adding an adjustible threshold for an amount of entries that would not trigger a preview would be great.

@tryashtar
Copy link
Owner

Got it! Thank you

@Haralil Haralil linked a pull request May 6, 2022 that will close this issue
Open
@tryashtar
Copy link
Owner

Am I correct to assume you've managed to build and use your modified copy? :)
Because if so, I'm going to hold off on fixing it myself for a while, until it becomes necessary 😂

@Haralil
Copy link
Author

Haralil commented May 8, 2022

Sorry for the late response, yes, I builded it and finished what I was doing. The time improved from ~5 minutes per search to being less than a minute long, approximately.
You can test my fix yourself, if you want, and add it now, but I don't think that's necessary and you'll probably do a better job than me & will probably add an additional setting for this to work better, I just don't feel like dealing with that right now :)

Just wanted to point out a potential fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Temporary fix for searches taking too long with lots of found entries. Haralil/nbt-studio
2 participants
@Haralil @tryashtar