Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcb_hole element doesn't render #47

Open
seveibar opened this issue Sep 5, 2024 · 18 comments
Open

pcb_hole element doesn't render #47

seveibar opened this issue Sep 5, 2024 · 18 comments
Labels

Comments

@seveibar
Copy link
Contributor

seveibar commented Sep 5, 2024

Example file:

[
  {
    "type": "pcb_board",
    "pcb_board_id": "pcb_board_0",
    "center": {
      "x": 0,
      "y": 0
    },
    "width": 10,
    "height": 10
  },
  {
    "type": "pcb_hole",
    "pcb_hole_id": "pcb_hole_0",
    "hole_shape": "round",
    "hole_diameter": 2.031999934976002,
    "x": 3,
    "y": 1
  }
]

It should render like this:

image

Copy link

homie-gg bot commented Sep 5, 2024

This might have already been done via: implement Hole and pcb_hole rendering.

Copy link

homie-gg bot commented Sep 5, 2024

Copy link

homie-gg bot commented Sep 6, 2024

Here are some pull requests that might be helpful reference for this task:

Copy link

homie-gg bot commented Sep 6, 2024

This might have already been done via: add support for rendering holes onto board.

Copy link

homie-gg bot commented Sep 7, 2024

This might have already been done via: Detect round holes as obstacles fix.

@tscircuitbot
Copy link

Aider has created a pull request to address this issue: undefined

Please review the changes and provide feedback.

@seveibar
Copy link
Contributor Author

seveibar commented Sep 9, 2024

@abhijitxy this one is a good option

@abhijitxy abhijitxy self-assigned this Sep 10, 2024
Copy link

homie-gg bot commented Sep 16, 2024

This might have already been done via: updated circuit-to-svg and dependency.

@seveibar
Copy link
Contributor Author

@abhijitxy is this one done?

@seveibar
Copy link
Contributor Author

@abhijitxy

@abhijitxy abhijitxy removed their assignment Sep 17, 2024
Copy link

homie-gg bot commented Sep 20, 2024

Copy link

homie-gg bot commented Sep 20, 2024

This might have already been done via: Fix hole shape enum issue.

Copy link

homie-gg bot commented Sep 20, 2024

This might have already been done via: support for plated holes and holes.

Copy link

homie-gg bot commented Sep 20, 2024

This might have already been done via: PCB Element Refactor, docs file for PCB Elements for better AI-assist.

Copy link

homie-gg bot commented Sep 20, 2024

This might have already been done via: Add support for rendering pcb_hole.

Copy link

homie-gg bot commented Sep 21, 2024

This might have already been done via: support correct pin positions for schematic box.

Copy link

homie-gg bot commented Sep 23, 2024

This might have already been done via: Update 3d viewer, core and pcb viewer. Add switches to keyboard example.

Copy link

homie-gg bot commented Sep 30, 2024

This might have already been done via: implemented pcb_hole in excellon drill and soldermask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

3 participants