Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotation as a prop to <Rotate /> (alias of angles) #38

Closed
seveibar opened this issue Jul 23, 2024 · 3 comments
Closed

Add rotation as a prop to <Rotate /> (alias of angles) #38

seveibar opened this issue Jul 23, 2024 · 3 comments

Comments

@seveibar
Copy link
Contributor

          instead of `angles` we should accept `rotation`, going to create an issue to add that as an accepted prop (we can accept both)

Originally posted by @seveibar in #37 (comment)

@Slaviiiii
Copy link
Contributor

You want me to replace angles with rotation?
I think jscad requires it to be called that way.

@seveibar
Copy link
Contributor Author

@Slaviiiii it's just an alias, so we accept either then give jscad the one it requires. <Translate /> does this too by accepting either center or offset

@Slaviiiii
Copy link
Contributor

@seveibar I see what you mean with this.
Get the required rotation prop and then make angles={rotation}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants