Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed:Search box doesn't render well in small views and dashboard responsiveness #85

Merged
merged 8 commits into from
Oct 18, 2024

Conversation

theajmalrazaq
Copy link
Contributor

i have fixed issue #83 Search box doesn't render well in small views please add hacktobefest label
image

Copy link

vercel bot commented Oct 18, 2024

@theajmalrazaq is attempting to deploy a commit to the tscircuit Team on Vercel.

A member of the Team first needs to authorize it.

@seveibar
Copy link
Contributor

Can you show a screenshot with a mobile view

package.json Outdated Show resolved Hide resolved
@seveibar
Copy link
Contributor

Ah mobile view is different. This fix seems OK but i think we might want to improve the search bar there- its super small on md. I think maybe we could use a shadcn command modal when someone clicks the box on small screens?

@theajmalrazaq
Copy link
Contributor Author

i think it seems perfect on mobile devices
image

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@theajmalrazaq theajmalrazaq changed the title fixed:Search box doesn't render well in small views fixed:Search box doesn't render well in small views and dashboard responsiveness Oct 18, 2024
@theajmalrazaq
Copy link
Contributor Author

theajmalrazaq commented Oct 18, 2024

@seveibar i also made dashboard responsive on mobile kindly review and merge
Screenshot_select-area_20241018202347

Screenshot_select-area_20241018202317

@seveibar
Copy link
Contributor

I would run "bun format" after editing, the first pr for a person on github i have to manually approve workflows

@theajmalrazaq
Copy link
Contributor Author

Hi @seveibar,
I sincerely apologize for the confusion caused. As a beginner, this is my first time contributing to a large open-source project, and I appreciate your understanding. Please kindly disregard any mistakes made.

@seveibar
Copy link
Contributor

No worries! Just letting you know the first pr is always tricky and you might have to ping me more often 😁

@theajmalrazaq
Copy link
Contributor Author

theajmalrazaq commented Oct 18, 2024

Haha, I think I’ve already pinged you more than 10 times! 😅 I really love your project and I’m excited to contribute more, especially with frontend bugs. You can definitely expect more pings from me!

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, future contributions will auto-run checks which will make things easier

@seveibar seveibar merged commit 00b782e into tscircuit:main Oct 18, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants