From 9dcac6ceefbc83aabf3a34dce8791a870deaf946 Mon Sep 17 00:00:00 2001 From: Charles Cooper Date: Sun, 7 Jan 2024 12:30:20 -0500 Subject: [PATCH] allow iterating over subscript --- .../features/iteration/test_for_in_list.py | 19 ++++++++++++------- vyper/semantics/analysis/local.py | 3 --- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/tests/functional/codegen/features/iteration/test_for_in_list.py b/tests/functional/codegen/features/iteration/test_for_in_list.py index 34f511a245..5c7b5c6b1b 100644 --- a/tests/functional/codegen/features/iteration/test_for_in_list.py +++ b/tests/functional/codegen/features/iteration/test_for_in_list.py @@ -418,6 +418,18 @@ def a() -> int128: return x""", -14, ), + ( + """ +@external +def a() -> uint256: + a: DynArray[DynArray[uint256, 2], 3] = [[0, 1], [2, 3], [4, 5]] + x: uint256 = 0 + for i: uint256 in a[2]: + x += i + return x + """, + 9, + ), ] @@ -791,13 +803,6 @@ def test_for() -> int128: """, TypeMismatch, ), - """ -@external -def foo(): - a: DynArray[DynArray[uint256, 2], 3] = [[0, 1], [2, 3], [4, 5]] - for i: uint256 in a[2]: - pass - """, ] BAD_CODE = [code if isinstance(code, tuple) else (code, StructureException) for code in BAD_CODE] diff --git a/vyper/semantics/analysis/local.py b/vyper/semantics/analysis/local.py index d5af3e243a..d66ec1f591 100644 --- a/vyper/semantics/analysis/local.py +++ b/vyper/semantics/analysis/local.py @@ -344,9 +344,6 @@ def visit_Expr(self, node): self.expr_visitor.visit(node.value, fn_type) def visit_For(self, node): - if isinstance(node.iter, vy_ast.Subscript): - raise StructureException("Cannot iterate over a nested list", node.iter) - if not isinstance(node.target.target, vy_ast.Name): raise StructureException("Invalid syntax for loop iterator", node.target.target)