Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the purpose of the test builds during setup? #692

Open
elchenberg opened this issue Feb 28, 2024 · 0 comments
Open

What is the purpose of the test builds during setup? #692

elchenberg opened this issue Feb 28, 2024 · 0 comments

Comments

@elchenberg
Copy link
Contributor

It seems to me that the results of the test builds (success or failure) are completely ignored. Should we remove them then?

dind-nurse/pkg/setup.go

Lines 23 to 27 in 9bde468

testBuild(ctx)
testBuildx(ctx)
return nil

If we do not delete them: Why should they fail when we already know (from awaitDocker) that the daemon is running? And if they fail, shouldn't there be some kind consequences (for example throwing an error so the container restarts or marking the container NotReady)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant