Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent URL store #67

Open
dr-chase-g3ka1 opened this issue Oct 17, 2022 · 3 comments
Open

Persistent URL store #67

dr-chase-g3ka1 opened this issue Oct 17, 2022 · 3 comments

Comments

@dr-chase-g3ka1
Copy link

Is your feature request related to a problem? Please describe.
When the upload is interrupted by for example a power outage, the upload must restart. That is because only MemoryURLStore exists.

Describe the solution you'd like
There should be a persistent URL store which could be loaded after a restart of the computer.

Can you provide help with implementing this feature?
I have some code and I will create a pull request.

Additional context
It's a feature that was requested by my boss, but we are moving to AWS cloud, so our old infrastructure will not be updated. Thus I don't want my efforts wasted, the tus team might like this solution. I hope.

@Acconut
Copy link
Member

Acconut commented Oct 18, 2022

Thank you very much for your work on this feature. In general, we are interested in adding such a persistent URL storage.

It's a feature that was requested by my boss, but we are moving to AWS cloud, so our old infrastructure will not be updated. Thus I don't want my efforts wasted

That's very noble of you! Would you still be open for modification on your PR? I am mostly thinking about adding tests and discussing the actual data format (is XML really the best choice here?).

@dr-chase-g3ka1
Copy link
Author

dr-chase-g3ka1 commented Oct 18, 2022

I am open to continue to work on the PR, I have some time during evenings. I think XML (JAXB) is good enough if we assume the typical client uploads 1-2 large files at a time because of bandwidth limitation. JAXB with these annotations is very simple in the code, easy to maintain. Also, the xml file is in temp folder, so operating system should be able to pick up and clean automatically. Only concern is JAXB is not included after JRE1.8 so that might be an issue. Other solution could be SQLite maybe. If you have a better solution in mind feel free to share.

@Acconut
Copy link
Member

Acconut commented Feb 11, 2023

Thanks for your work! We continued the discussion in #68.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants