Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when toot contains quote toot by same author #4725

Open
tomayac opened this issue Oct 14, 2024 · 5 comments
Open

Crash when toot contains quote toot by same author #4725

tomayac opened this issue Oct 14, 2024 · 5 comments
Labels

Comments

@tomayac
Copy link

tomayac commented Oct 14, 2024

Detailed description

Hard crash when reaching a toot with a quote toot of the same author.

Steps to reproduce the problem

Debug information

Tusky 26.2

Device:

Google Pixel 8 Pro
Android version: 15
SDK version: 35

Account:

@tomayac@toot.cafe
Version: 4.2.13

@tomayac tomayac added the bug label Oct 14, 2024
@connyduck
Copy link
Collaborator

I can reproduce a crash here, but not because it is a self quote, rather because the link preview card has a very weird image attached.

@tomayac do you have the "show link previews in timelines" setting turned on?

@tomayac
Copy link
Author

tomayac commented Oct 15, 2024

Oh, wait. Found the "Show link previews in timelines" setting. It was on. If I turn it off, the crash doesn't occur anymore. So this is definitely the culprit. Let me know if or how I can help debug this.

@connyduck
Copy link
Collaborator

That confirms that the crash I can reproduce is the same as yours! Thanks for reporting, will fix.

@tomayac
Copy link
Author

tomayac commented Oct 16, 2024

Thank you for working on Tusky <3! So the problem is essentially this 661 x 2 image.

c35b698b606557ec

@connyduck
Copy link
Collaborator

Well strictly speaking the problem is that Tusky doesn't account for weird aspect ratios when loading the preview card image 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants