Getting rid of a circular dependency between bijection-macros and chill #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I'm not so sure this is the best approach. I think bijection-macros should be killed. We should move the macros into bijection (no need for a new package). Also, the IsCaseClass and MacroGenerated traits are really not useful. They were something generated when we were making the first few macros, but they are not valuable, as far as I can see (we later noticed other ways to do the same thing). |
|
That said, we could merge this and just take on killing bijection-macros as an issue. |
|
@johnynek yeah - my preference would be to kill bijection-macros as a separate issue. Thanks for looking at this. |
|
added #229 |
johnynek
added a commit
that referenced
this pull request
Sep 3, 2015
Getting rid of a circular dependency between bijection-macros and chill
|
That was quick - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bijection and Chill now have a circular dependency between each other. This is because com.twitter.chill.Externalizer is used for the bijection-macros test.
I cherrypicked and simplified the Externalizer, and moved it into the TestHelpers in bijection-macros.