Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

Deactivate light when charging #1454

Open
CesarHerreraG opened this issue May 15, 2020 · 12 comments
Open

Deactivate light when charging #1454

CesarHerreraG opened this issue May 15, 2020 · 12 comments

Comments

@CesarHerreraG
Copy link

CesarHerreraG commented May 15, 2020

With OTA 12 it appears a light when you charge rhe batery. This may deteriorate the diode.

@wdehoog
Copy link

wdehoog commented May 15, 2020

There is a PR for unity to address your concern: ubports/unity8#283.

Considering the lifetimes of leds and of phones I doubt the led may deteriorate in a way you will be able to notice though.

@CesarHerreraG
Copy link
Author

ok

@FlavioMala
Copy link

FlavioMala commented May 15, 2020

It depend on how much current the designer has decided to “pump“ into the led, its characteristics, working temperature, etc.
keep in mind also that “charging“ occurs for a limited time...
In conclusion, what wdehoog wrote is perfectly applicable!
(But an on/off button somewhere should be a good thing.)

@CesarHerreraG
Copy link
Author

ok again.

@CesarHerreraG
Copy link
Author

You could close if you want.

@wdehoog
Copy link

wdehoog commented May 15, 2020

You have a valid wish: to be able to tun of the charging notification using the led. There is a PR to do just that. (Not very friendly yet though. No UI to disable/enable it.)
So I think we should keep the issue open.

@CesarHerreraG
Copy link
Author

Thanks.

@gbdomubpkm
Copy link

Totally agree to have the possibility to disable the diode.
But an idea : if it is feasible, whether the phone is charging while being switched on or off, the LED could only be switched on, for example, as soon as 90% of the full charge is reached to signal that we are getting closer to the goal.

@wdehoog
Copy link

wdehoog commented May 17, 2020

So where should the switch to en-/disable the charging indicator be available?

The PR already allows to do so using the terminal command:
dconf write /com/lomiri/ledindication/charging-state-visible false. Is that acceptable and sufficient?

I can't find a good place in the system settings for it. Adding a switch to the battery indicator seems more appropriate.

@Flohack74
Copy link
Member

Hmm I think Android does this in the same way, and also there you have no option to turn it off. So, lifetime considerations should be no issue, otherwise Android would probably already offered a similar option.

@CesarHerreraG
Copy link
Author

Ok.

@mateosalta
Copy link

So where should the switch to en-/disable the charging indicator be available?

The PR already allows to do so using the terminal command:
dconf write /com/lomiri/ledindication/charging-state-visible false. Is that acceptable and sufficient?

I can't find a good place in the system settings for it. Adding a switch to the battery indicator seems more appropriate.

that would be a good solution for the short term, we could always add it into the uttweak tool for advanced users

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants