From e68742c8231cd1aa6061d808e1056482aae9601a Mon Sep 17 00:00:00 2001
From: Jarvis <113449836+jarvisraymond-uchicago@users.noreply.github.com>
Date: Wed, 9 Oct 2024 14:48:53 -0500
Subject: [PATCH] Bugfix/vadc defect20 unlabeled3 button (#1603)

* PPS-1564 PPS-1567 PPS-1585: update guppy to 0.19.1 (#1601)

* bugfix(vadcDefect20Unlabled3Button): initial commit

* bugfix(vadcDefect20Unlabled3Button): reverted unintentionally changed files

---------

Co-authored-by: Shawn O'Connor <ocshawn@ocshawn.com>
---
 .../TeamProject/TeamProjectHeader/Icons/EditIcon.jsx       | 1 -
 .../TeamProject/TeamProjectHeader/TeamProjectHeader.css    | 4 ++++
 .../TeamProject/TeamProjectHeader/TeamProjectHeader.jsx    | 7 ++++---
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/Analysis/SharedUtils/TeamProject/TeamProjectHeader/Icons/EditIcon.jsx b/src/Analysis/SharedUtils/TeamProject/TeamProjectHeader/Icons/EditIcon.jsx
index 71cbdd5ade..ce10706064 100644
--- a/src/Analysis/SharedUtils/TeamProject/TeamProjectHeader/Icons/EditIcon.jsx
+++ b/src/Analysis/SharedUtils/TeamProject/TeamProjectHeader/Icons/EditIcon.jsx
@@ -2,7 +2,6 @@ import React from 'react';
 
 const EditIcon = () => (
   <svg
-    role='button'
     xmlns='http://www.w3.org/2000/svg'
     width='16'
     height='16'
diff --git a/src/Analysis/SharedUtils/TeamProject/TeamProjectHeader/TeamProjectHeader.css b/src/Analysis/SharedUtils/TeamProject/TeamProjectHeader/TeamProjectHeader.css
index ad0df24619..44c448a179 100644
--- a/src/Analysis/SharedUtils/TeamProject/TeamProjectHeader/TeamProjectHeader.css
+++ b/src/Analysis/SharedUtils/TeamProject/TeamProjectHeader/TeamProjectHeader.css
@@ -12,6 +12,10 @@
 .team-project-header_modal-button {
   margin-left: 10px;
   cursor: pointer;
+  border: none;
+  background: none;
+  height: auto;
+  width: auto;
 }
 
 .team-project-header_modal-button:hover {
diff --git a/src/Analysis/SharedUtils/TeamProject/TeamProjectHeader/TeamProjectHeader.jsx b/src/Analysis/SharedUtils/TeamProject/TeamProjectHeader/TeamProjectHeader.jsx
index 2f9196b581..38920976d1 100644
--- a/src/Analysis/SharedUtils/TeamProject/TeamProjectHeader/TeamProjectHeader.jsx
+++ b/src/Analysis/SharedUtils/TeamProject/TeamProjectHeader/TeamProjectHeader.jsx
@@ -59,10 +59,11 @@ const TeamProjectHeader = ({ isEditable }) => {
       <div className='team-project-header'>
         <strong>Team Project</strong> / {bannerText}
         {isEditable && (
-          <span
+          <button
             className='team-project-header_modal-button'
+            aria-label='Change Team Project'
+            type='button'
             tabIndex='0'
-            role='button'
             data-testid='team-project-edit'
             onClick={() => {
               showModal();
@@ -72,7 +73,7 @@ const TeamProjectHeader = ({ isEditable }) => {
             }}
           >
             <EditIcon />
-          </span>
+          </button>
         )}
       </div>
       {isEditable && (