Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) Fix button path to edit_organization from organization dashboard #261

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

klinkoberstar
Copy link
Contributor

Describe your changes

This PR will close #259

  • Changes how the organization is retrieved (from the Org ID rather than current user). This approach aligns with how the similar task is performed in the admin dashboard
  • Updates translation JSON to remove hardcoding of org resources
  • Remove unused post requests in edit_organization and authorize.edit_organization

Non-obvious technical information

This bug was a result of how Organization was accessed and passed into edit_organization.html. The bug has been resolved by passing organization_id as a parameter, rather than extracting it in relation to the current user.

Checklist before requesting a review

  • pre-commit run --all-files (run before pushing)
  • pytest if applicable
  • Link issue
  • Update relevant documentation if applicable: doc strings, readme, poetry.

@klinkoberstar klinkoberstar linked an issue Jun 13, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin & Org routes to org dashboard
1 participant