-
Notifications
You must be signed in to change notification settings - Fork 19
/
immer-non-support.test.ts
723 lines (648 loc) · 16.4 KB
/
immer-non-support.test.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
/* eslint-disable @typescript-eslint/no-unused-vars */
/* eslint-disable no-inner-declarations */
/* eslint-disable symbol-description */
/* eslint-disable no-unused-expressions */
/* eslint-disable @typescript-eslint/ban-ts-comment */
/* eslint-disable prefer-destructuring */
/* eslint-disable no-param-reassign */
/* eslint-disable no-lone-blocks */
import {
produce,
enableMapSet,
setAutoFreeze,
Immutable,
produceWithPatches,
enablePatches,
applyPatches,
setUseStrictShallowCopy,
current as immerCurrent,
createDraft,
finishDraft,
immerable,
} from 'immer';
import { create, apply, current } from '../src';
enableMapSet();
beforeEach(() => {
setAutoFreeze(true);
});
test('Set draft constructor is not equal to Set', () => {
{
const data = new Set([1, 2, 3]);
produce(data, (draft) => {
expect(draft.constructor).not.toBe(Set);
});
}
{
const data = new Set([1, 2, 3]);
create(data, (draft) => {
expect(draft.constructor).toBe(Set);
});
}
});
test('Map draft constructor is not equal to Map', () => {
{
const data = new Map([[1, 'a']]);
produce(data, (draft) => {
expect(draft.constructor).not.toBe(Map);
});
}
{
const data = new Map([[1, 'a']]);
create(data, (draft) => {
expect(draft.constructor).toBe(Map);
});
}
});
test('Unexpected operation check of Set draft', () => {
{
const data = new Set([1]);
// ! it should throw an error
expect(() => {
produce(data, (draft) => {
// @ts-ignore
draft.x = 1;
});
}).not.toThrowError();
}
{
const data = new Set([1]);
expect(() => {
create(data, (draft) => {
// @ts-ignore
draft.x = 1;
});
}).toThrowError(`Map/Set draft does not support any property assignment.`);
}
});
test('Unexpected operation check of Map draft', () => {
{
const data = new Map([[1, 'a']]);
// ! it should throw an error
expect(() => {
produce(data, (draft) => {
// @ts-ignore
draft.x = 1;
});
}).not.toThrowError();
}
{
const data = new Map([[1, 'a']]);
expect(() => {
create(data, (draft) => {
// @ts-ignore
draft.x = 1;
});
}).toThrowError(`Map/Set draft does not support any property assignment.`);
}
});
test('immer failed case - freeze Map key', () => {
{
setAutoFreeze(true);
const base = new Map<{ a: number }, number>([[{ a: 1 }, 1]]);
const state: Immutable<Map<{ a: number }, number>> = produce(
base,
(draft) => {
draft.values().next().value = 2;
}
);
// ! it should throw error about freeze
expect(() => {
// @ts-ignore
Array.from(state.keys())[0].a = 2;
}).not.toThrowError();
}
{
const base = new Map<{ a: number }, number>([[{ a: 1 }, 1]]);
const state = create(
base,
(draft) => {
draft.values().next().value = 2;
},
{
enableAutoFreeze: true,
}
);
expect(() => {
// @ts-ignore
Array.from(state.keys())[0].a = 2;
}).toThrowError();
}
});
test('immer failed case - escaped draft', () => {
{
setAutoFreeze(false);
const dataSet = [{}, {}, {}] as any;
const data = {
data: null,
a: {
b: 1,
},
};
const state = produce(data, (draft) => {
draft.data = dataSet;
const a = draft.a;
dataSet[0] = a;
dataSet[1].a = { b: 1, c: [a] };
draft.a.b = 2;
});
expect(() => {
JSON.stringify(state);
}).toThrowError();
}
{
const dataSet = [{}, {}, {}] as any;
const data = {
data: null,
a: {
b: 1,
},
};
const state = create(data, (draft) => {
draft.data = dataSet;
const a = draft.a;
dataSet[0] = a;
dataSet[1].a = { b: 1, c: [a] };
draft.a.b = 2;
});
expect(() => {
JSON.stringify(state);
}).not.toThrowError();
}
});
// https://github.com/immerjs/immer/issues/1012
test('Unexpected access to getter property in irrelevant plain objects', () => {
{
setAutoFreeze(false);
let isAgeGetterCalled = false;
const state = {
data: {
data: {
lisa: {
name: 'lisa',
get age() {
console.log('age getter called');
isAgeGetterCalled = true;
return 18;
},
},
},
},
other: { a: 9 },
};
const value = produce(state, (draft) => {
console.log('immer produce enter');
draft.other.a = 6;
console.log('immer produce exit');
});
console.log('immer + isAgeGetterCalled', isAgeGetterCalled);
expect(isAgeGetterCalled).toBe(true);
// Expect: false
// output: true
// ↑ Error here, in this case,
// the getter should not called, when `setAutoFreeze(false)`
}
{
let isAgeGetterCalled = false;
const state = {
data: {
data: {
lisa: {
name: 'lisa',
get age() {
console.log('age getter called');
isAgeGetterCalled = true;
return 18;
},
},
},
},
other: { a: 9 },
};
const value = create(state, (draft) => {
console.log('mutative create enter');
draft.other.a = 6;
console.log('mutative create exit');
});
console.log();
console.log('mutative + isAgeGetterCalled', isAgeGetterCalled);
expect(isAgeGetterCalled).toBe(false);
}
});
test('circular reference', () => {
{
const data = { a: { b: { c: 1 } } };
// @ts-expect-error
data.a.b.c1 = data.a.b;
setAutoFreeze(true);
expect(() => {
produce(data, () => {
//
});
}).not.toThrowError();
}
{
const data = { a: { b: { c: 1 } } };
// @ts-expect-error
data.a.b.c1 = data.a.b;
expect(() => {
create(
data,
(draft) => {
//
},
{
enableAutoFreeze: true,
}
);
}).toThrowErrorMatchingInlineSnapshot(
`"Forbids circular reference: ~/a/b"`
);
}
});
test('#18 - set: assigning a non-draft with the same key - 1', () => {
const baseState = {
array: [
{
one: {
two: {
three: 3,
},
},
},
],
};
{
const created = create(
baseState,
(draft) => {
draft.array[0].one.two.three = 2;
const two = draft.array[0].one.two;
const one = new Set();
// @ts-ignore
draft.array = [{ one }];
// @ts-ignore
one.add(two);
// @ts-ignore
expect(Array.from(draft.array[0].one)[0].three).toBe(2);
},
{
enablePatches: true,
}
);
// @ts-ignore
expect(Array.from(created[0].array[0].one)[0].three).toBe(2);
expect(apply(baseState, created[1])).toEqual(created[0]);
expect(apply(created[0], created[2])).toEqual(baseState);
}
{
enablePatches();
// @ts-ignore
const produced = produceWithPatches(baseState, (draft: any) => {
draft.array[0].one.two.three = 2;
const two = draft.array[0].one.two;
const one = new Set();
// @ts-ignore
draft.array = [{ one }];
// @ts-ignore
one.add(two);
// @ts-ignore
expect(Array.from(draft.array[0].one)[0].three).toBe(2);
});
// @ts-ignore
expect(() => {
// @ts-ignore
// eslint-disable-next-line no-unused-expressions
Array.from(produced[0].array[0].one)[0].three;
}).toThrowError();
// @ts-ignore
expect(() => applyPatches(baseState, produced[1])).toThrowError();
// @ts-ignore
expect(applyPatches(produced[0], produced[2])).toEqual(baseState);
}
});
test('#18 - set: assigning a non-draft with the same key - 2', () => {
const baseState = { c: [{ a: 1 }, { a: 1 }] };
{
enablePatches();
// @ts-ignore
const produced = produceWithPatches(baseState, (draft) => {
const f = draft.c.pop();
// @ts-ignore
f.a = 2;
// @ts-ignore
draft.c = new Set([draft.c[0], f]);
});
// @ts-ignore
expect(() => applyPatches(baseState, produced[1])).toThrowError();
// @ts-ignore
expect(applyPatches(produced[0], produced[2])).toEqual(baseState);
}
{
const created = create(
baseState,
(draft) => {
const f = draft.c.pop();
// @ts-ignore
f.a = 2;
// @ts-ignore
draft.c = new Set([draft.c[0], f]);
},
{
enablePatches: true,
}
);
expect(apply(baseState, created[1])).toEqual(created[0]);
expect(apply(created[0], created[2])).toEqual(baseState);
}
});
test('enablePatches and assign with ref array', () => {
const baseState = { a: { b: { c: 1 } }, arr0: [{ a: 1 }], arr1: [{ a: 1 }] };
const fn = (draft: any) => {
draft.arr0.push(draft.a.b);
draft.arr0.push(draft.arr1);
draft.a.b.c = 2;
draft.a.b.c = 333;
delete draft.a.b;
draft.arr1[0].a = 222;
draft.arr0[1].a = 333;
draft.arr0[2][0].a = 444;
};
{
enablePatches();
const [state, patches, inversePatches] = produceWithPatches(baseState, fn);
const mutatedResult = JSON.parse(JSON.stringify(baseState));
fn(mutatedResult);
expect(state).toEqual(mutatedResult);
const prevState = applyPatches(state, inversePatches);
// !!! it should be equal
expect(prevState).not.toEqual(baseState);
const nextState = applyPatches(baseState, patches);
// !!! it should be equal
expect(nextState).not.toEqual(state);
}
{
const [state, patches, inversePatches] = create(baseState, fn, {
enablePatches: true,
});
const mutatedResult = JSON.parse(JSON.stringify(baseState));
fn(mutatedResult);
expect(state).toEqual(mutatedResult);
const prevState = apply(state, inversePatches);
expect(prevState).toEqual(baseState);
const nextState = apply(baseState, patches);
expect(nextState).toEqual(state);
}
});
test('produce leaks proxy objects when symbols are present', () => {
{
setUseStrictShallowCopy(true);
const Parent = Symbol();
const testObject = {
name: 'Parent',
};
// @ts-ignore
testObject.child = {
[Parent]: testObject,
count: 0,
};
// https://github.com/immerjs/immer/issues/1106
// it should not throw error
expect(() => {
const result = produce(testObject, (draft) => {
// @ts-ignore
draft.child.count++;
});
}).toThrowError();
}
{
const Parent = Symbol();
const testObject = {
name: 'Parent',
};
// @ts-ignore
testObject.child = {
[Parent]: testObject,
count: 0,
};
// it should not throw error
expect(() => {
const result = create(testObject, (draft) => {
// @ts-ignore
draft.child.count++;
});
}).not.toThrowError();
}
});
test('error key setting in array', () => {
{
for (const key of [-1, '-1', '1.0', '-1.1']) {
const data = [1, 2, 3];
expect(() => {
produce(data, (draft) => {
// @ts-ignore
draft[key] = 'new str';
});
}).not.toThrowError();
}
}
{
for (const key of [-1, '-1', '1.0', '-1.1']) {
const data = [1, 2, 3];
expect(() => {
create(data, (draft) => {
// @ts-ignore
draft[key] = 'new str';
});
}).toThrowErrorMatchingSnapshot();
}
}
});
test(`Object values of a Map are not frozen anymore #1119`, () => {
{
enableMapSet();
interface Fruit {
key: string;
name: string;
}
const fruits: Fruit[] = [
{ key: 'apple1', name: 'Red Delicious' },
{ key: 'apple2', name: 'Gala' },
];
let products = new Map<string, Fruit>();
function setFruitMap(fruits: Fruit[]): void {
products = produce(products, (draft) => {
draft.clear();
fruits.forEach((fruit) => draft.set(fruit.key, fruit));
});
}
setFruitMap(fruits);
const product = products.get('apple1');
// ! it should be frozen
expect(Object.isFrozen(product)).not.toBeTruthy();
}
{
interface Fruit {
key: string;
name: string;
}
const fruits: Fruit[] = [
{ key: 'apple1', name: 'Red Delicious' },
{ key: 'apple2', name: 'Gala' },
];
let products: Immutable<Map<string, Fruit>> = new Map();
function setFruitMap(fruits: Fruit[]): void {
products = create(
products,
(draft) => {
draft.clear();
fruits.forEach((fruit) => draft.set(fruit.key, fruit));
},
{
enableAutoFreeze: true,
}
);
}
setFruitMap(fruits);
const product = products.get('apple1');
expect(Object.isFrozen(product)).toBeTruthy();
}
});
test('#47 Avoid deep copies', () => {
{
const obj = { k: 42 };
const base = { x: { y: { z: obj } } };
produce(base, (draft) => {
draft.x = { y: { z: obj } };
const c = immerCurrent(draft);
// ! it should be equal
expect(c.x.y.z).not.toBe(obj);
});
}
{
const obj = { k: 42 };
const base = { x: { y: { z: obj } } };
create(base, (draft) => {
draft.x = { y: { z: obj } };
const c = current(draft);
expect(c.x.y.z).toBe(obj);
});
}
});
test('#61 - type issue: current of Draft<T> type should return T type', () => {
{
function test<T extends { x: { y: ReadonlySet<string> } }>(base: T): T {
const draft = createDraft(base);
// @ts-ignore
const currentValue: T = immerCurrent(draft); // !!! Type Draft<T> is not assignable to type T
// @ts-expect-error
return finishDraft(draft);
}
expect(test({ x: { y: new Set(['a', 'b']) } })).toEqual({
x: { y: new Set(['a', 'b']) },
});
}
{
function test<T extends { x: { y: ReadonlySet<string> } }>(base: T): T {
const [draft, f] = create(base);
const currentValue: T = current(draft);
return f();
}
expect(test({ x: { y: new Set(['a', 'b']) } })).toEqual({
x: { y: new Set(['a', 'b']) },
});
}
});
test('set - new Set API', () => {
// @ts-ignore
if (!Set.prototype.difference) {
console.warn('Set.prototype.difference is not supported');
return;
}
{
enableMapSet();
const odds = new Set([1, 3, 5, 7, 9]);
const squares = new Set([1, 4, 9]);
const state = produce(odds, (draft) => {
// @ts-ignore
expect(draft.intersection(squares)).toEqual(new Set([])); // it should be `new Set([1, 9])`
});
}
{
const odds = new Set([1, 3, 5, 7, 9]);
const squares = new Set([1, 4, 9]);
const state = create(odds, (draft) => {
// @ts-ignore
expect(draft.intersection(squares)).toEqual(new Set([1, 9]));
});
}
});
test('CustomSet', () => {
{
enableMapSet();
class CustomSet extends Set {
[immerable] = true;
getIdentity() {
return 'CustomSet';
}
}
const s = new CustomSet();
const newS = produce(s, (draft) => {
draft.add(1);
// @ts-ignore
expect(typeof draft.getIdentity === 'function').toBeFalsy(); // it should be `true`
});
// @ts-ignore
expect(typeof newS.getIdentity === 'function').toBeFalsy(); // it should be `true`
}
{
class CustomSet extends Set {
getIdentity() {
return 'CustomSet';
}
}
const state = new CustomSet();
const newState = create(state, (draft) => {
draft.add(1);
// @ts-ignore
expect(draft.getIdentity()).toBe('CustomSet');
});
expect(newState instanceof CustomSet).toBeTruthy();
// @ts-ignore
expect(newState.getIdentity()).toBe('CustomSet');
}
});
test('CustomMap', () => {
{
enableMapSet();
class CustomMap extends Map {
[immerable] = true;
getIdentity() {
return 'CustomMap';
}
}
const state = new CustomMap();
const newState = produce(state, (draft) => {
draft.set(1, 1);
// @ts-ignore
expect(typeof draft.getIdentity === 'function').toBeFalsy(); // it should be `true`
});
// @ts-ignore
expect(typeof newState.getIdentity === 'function').toBeFalsy(); // it should be `true`
}
{
class CustomMap extends Map {
getIdentity() {
return 'CustomMap';
}
}
const state = new CustomMap();
const newState = create(state, (draft) => {
draft.set(1, 1);
// @ts-ignore
expect(draft.getIdentity()).toBe('CustomMap');
});
expect(newState instanceof CustomMap).toBeTruthy();
// @ts-ignore
expect(newState.getIdentity()).toBe('CustomMap');
}
});