-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop eslint-plugin-sonarjs
#434
Comments
Interesting, thanks for the proposal! I've been waiting on upgrading to |
I would be interested in seeing the PR too - in case there's any chance that they would still approve and merge it, didn't see one in a first naive search |
I had a local copy of the repo and was trying to understand how they manage the monorepo and publish them to npm. But after experimenting here and there I eventually realize that I will have to submit a huge PR to change their building infrastructure completely. That's why I didn't submit a PR yet. |
Ok thanks for the details! cc @yassin-kammoun-sonarsource @vdiez in case you weren't aware of the size / dependency infrastructure issues with |
BTW, it sounds a bit ironic as their |
Hello all, thanks, @karlhorky, for the heads up. We are aware of the issues raised here. Just to share some insights about why we migrated from the
All the ESLint rules now sit under this folder. We are still in the process of improving v2 after this initial and drastic change, but hopefully, once we are in a stable situation, the ESLint plugin from Sonar will be a much better package than v1. Now Things that we have on our list:
Thanks Edit: Some background about this change: https://community.sonarsource.com/t/will-sonarjs-rules-be-available-in-eslint-plugin-sonarjs/42955/6 |
Looks like I still didn't find a clear location with a changelog / release notes yet. |
But the |
Hello @karlhorky and @SukkaW, changelog is still on Jira. We are looking for a proper changelog solution. As you can see in the release notes, the Typescript as peer dependency was supposed to be in the release, but we messed up during the release process. 3.0.1 will be released today with that fixed. About babel, the problem is that we need a parser for rule S125( |
Hello all, For information, we won't set typescript as a peer dependency: it does not fit the definition of a peer dependency. However, we made a mistake by fixing the version of We'll fix that by lowering the constraint on the typescript version to the one that we actually support: |
Hello all, we just added a new CHANGELOG.md mentioning the changes specific to the ESLint plugin. Cheers |
https://pkg-size.dev/eslint-plugin-sonarjs
eslint-plugin-sonarjs
includes@babel/core
,vue-eslint-parser
,eslint-plugin-react
,eslint-plugin-import
,typescript-eslint@v7
all in its dependencies, resulting in an installation size of 87 MiB. It is ridiculous.I have tried to submit a PR to
eslint-plugin-sonarjs
, but due to how they organize their monorepo and publish packages on npm, it seems impossible to move those dependencies to peer dependencies.eslint-config-upleveled
only uses a few rules fromeslint-plugin-sonarjs
, but most of them have a replacement:sonarjs/no-duplicated-branches
andsonarjs/no-identical-conditions
@typescript-eslint/plugin
sonarjs/prefer-single-boolean-return
eslint-plugin-sonarjs
doesn't work on type, so the rule can only detect boolean literal, which might be limited.The text was updated successfully, but these errors were encountered: