Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Guides for ML Models #1

Open
ChSatyaSavith opened this issue Jun 5, 2023 · 3 comments
Open

More Guides for ML Models #1

ChSatyaSavith opened this issue Jun 5, 2023 · 3 comments

Comments

@ChSatyaSavith
Copy link

I would like to add some of my notebooks in your repository, can i?

@urmel79
Copy link
Owner

urmel79 commented Jun 5, 2023

Hi @ChSatyaSavith,
you're welcome to do a proposal via a git pull request.
Cheers, Bjoern.

@urmel79
Copy link
Owner

urmel79 commented Jun 21, 2023

Hi @ChSatyaSavith,
thank you for your pull request.
I will look at it in the coming days, but at the moment I am very busy with work and private life. I ask for your understanding.
Cheers, Bjoern.

@urmel79
Copy link
Owner

urmel79 commented Jun 22, 2023

Hi @ChSatyaSavith,

thank you for your contribution.
I have imported it to a dev branch and had a look at it.
This morning I found time to review your new notebook. So here are my thoughts for improvement:

  • Your notebook does not follow the elaborated step-by-step structure of my course. That's why I moved it to the "./playground" subfolder where other experimental notebooks are located.
  • Since the entire repository and its PDF results are published under open source / open access licenses, there is a requirement to reference external media sources such as images. Please include the source and license terms (appropriate to the open access publication, of course). If this is not possible, please create the graphical content yourself and license it under Creative Commons.
  • The formulas should not be "borrowed" from external sources. They can be created very easily by yourself as LaTeX formulas. You can find an example in my tutorial in section "6.2.1 Normalization".

As soon as you have revised your notebook, I will merge it to the "main" branch.

Thank you very much and greetings,
Björn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants