Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set back AttachCurrentThread in jvm.cpp #663

Open
piiertho opened this issue Aug 19, 2024 · 1 comment
Open

Set back AttachCurrentThread in jvm.cpp #663

piiertho opened this issue Aug 19, 2024 · 1 comment

Comments

@piiertho
Copy link
Member

In #659 we had to change AttachCurrentThread to AttachCurrentThreadAsDaemon in order to be able to close JVM.
This is due to godotengine/godot#95809.
We need to revert this once fixed.

@CedNaru
Copy link
Member

CedNaru commented Sep 12, 2024

This issue has been solved on Godot's master branch. It should also be cherry-picked for Godot 4.3.1, so we can revert that change with the next Godot release.
Here the PR solving it: godotengine/godot#96760
I extensively tested the branch, I couldn't prevent the JVM shutting down anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants