Update build GN files / targets fully. #2

vade · 2017-01-30T19:42:44Z

Add Syphon dependencies to appropriate target
Add linker flags and framework flags to build.gn entries
Add 'build and copy' phase to copy Syphon.framework correctly via build.gn entry
Add 'install_name_tool' phase to to build.gn entries.
Ensure other tests / build targets are appropriately updated.

…nce it's been enabled (patchset #2 id:20001 of https://codereview.chromium.org/2841443002/ ) Reason for revert: This CL broke some Mac tests https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/40547 https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/40547 FindIt report: https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/40547 Original issue's description: > Include headless tests in all swarm version for Windows, since it's been enabled > Also, increase tests version for Mac (previously enabled in https://codereview.chromium.org/2783053002) > > BUG=686608 > > Review-Url: https://codereview.chromium.org/2841443002 > Cr-Commit-Position: refs/heads/master@{#472023} > Committed: https://chromium.googlesource.com/chromium/src/+/386add8ced87b5b0c91d4f91b0f3e41be71c3d2c TBR=dpranke@chromium.org,skyostil@chromium.org,dvallet@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686608 Review-Url: https://codereview.chromium.org/2887663002 Cr-Commit-Position: refs/heads/master@{#472041}

…t_cache.mm. (patchset #2 id:20001 of https://codereview.chromium.org/2881873002/ ) Reason for revert: Probably this CL causes many failures of iOS bots. For example, https://build.chromium.org/p/chromium.mac/builders/ios-simulator/builds/17573 Original issue's description: > Use TaskScheduler instead of SequencedWorkerPool in snapshot_cache.mm. > > SequencedWorkerPool is being deprecated in favor of TaskScheduler. > > BUG=667892 > R=jif@chromium.org > > Review-Url: https://codereview.chromium.org/2881873002 > Cr-Commit-Position: refs/heads/master@{#472052} > Committed: https://chromium.googlesource.com/chromium/src/+/aa5299ae23a57ca5dce00a11da3ac8e73849351f TBR=jif@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=667892 Review-Url: https://codereview.chromium.org/2889553002 Cr-Commit-Position: refs/heads/master@{#472065}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/37015fb470d8..dab2aa44c6cd $ git log 37015fb47..dab2aa44c --date=short --no-merges --format='%ad %ae %s' 2017-05-16 nednguyen Revert of Remove webrtc_rendering_stats TBMv1 metrics (patchset #2 id:20001 of https://codereview.chromium.org/2890443002/ ) 2017-05-16 rnephew Revert of [Telemetry][CodeHealth] Make unittests with fake platforms use fakes.FakePlatform (patchset #3 id:60001 of https://codereview.chromium.org/2889583003/ ) 2017-05-16 rnephew [Telemetry][CodeHealth] Make unittests with fake platforms use fakes.FakePlatform 2017-05-16 ctzsm Remove android-webview-shell 2017-05-16 rnephew [Telemetry] Add Expectation module that enables disabling benchmarks/stories 2017-05-16 perezju [common/battor] Fix errors while logging 2017-05-16 nednguyen Remove webrtc_rendering_stats TBMv1 metrics 2017-05-16 perezju [Telemetry] Stop tracing/metrics before closing the browser 2017-05-16 nednguyen Remove v8_gc_latency TBMv1 metric 2017-05-16 ulan Revert of Fix main frame detection in loading metrics. (patchset #7 id:120001 of https://codereview.chromium.org/2862103002/ ) 2017-05-15 jreck Quick fix to avoid corruption from binder_parser 2017-05-15 ctzsm Rename AndroidWebView.apk to WebViewInstrumentation.apk 2017-05-15 ulan Fix main frame detection in loading metrics. Created with: roll-dep src/third_party/catapult BUG=701938,711065,719447,720317,692112,701938,692112 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I01ecaf24a0ad46e599b4e1272e8bb6204cabf75f Reviewed-on: https://chromium-review.googlesource.com/507032 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#472336}

…patchset #2 id:20001 of https://codereview.chromium.org/2889723002/ ) Reason for revert: Caused layout tests failure: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/52495 Original issue's description: > Mojo JavaScript bindings: follow JavaScript naming rules. > > This patch makes sure the following names follows the JavaScript naming rules in the use_new_js_bindings mode: > - method names; > - parameter names; > - struct/union field names; > - namespaces. > > BUG=718614 > > Review-Url: https://codereview.chromium.org/2889723002 > Cr-Commit-Position: refs/heads/master@{#472260} > Committed: https://chromium.googlesource.com/chromium/src/+/40b5e68dcd6a93d50931898b2d180195966adac3 TBR=rockot@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=718614 Review-Url: https://codereview.chromium.org/2893543002 Cr-Commit-Position: refs/heads/master@{#472343}

Added test uncovered a stack-use-after-scope issue in AshTouchExplorationManager. Patch #2 fixes the issue. Refactor backdrop that is currently used in the maximized mode. The maximized mode creates a backdrop window so that a user will not see the content of windows behind the top window, in case it doesn't cover the entire window. (can happen if the maximize size is specified for example) This CL generalizes the backdrop code used in maximize mode as to create the backdrop in the following scenarios: 1) Has a aura::client::kHasBackdrop property = true. 2) BackdropDelegate::HasBackdrop(aura::Window* window) returns true. 3) Active ARC window when the spoken feedback is enabled. * Added delegate to check if the window should have a backdrop. Maximized mode always puts a backdrop. * Added kHasBackdrop property for a window that needs a backdrop even in clamshell. * Move the accessibility feature implemented in exo's backbround. This is useful and should be there even for non-arc/exo case. TBR=jamescook@chromium.org,reveman@chromium.org,sky@chromium.org BUG=721646 TEST=coverted by unit tests Review-Url: https://codereview.chromium.org/2884623002 Cr-Commit-Position: refs/heads/master@{#472401} Committed: https://chromium.googlesource.com/chromium/src/+/04936c54ed2396ae54cd824e24f11151e0e11948 patch from issue 2884623002 at patchset 220001 (http://crrev.com/2884623002#ps220001) Review-Url: https://codereview.chromium.org/2890733005 Cr-Commit-Position: refs/heads/master@{#472479}

…se a crash (patchset #2 id:20001 of https://codereview.chromium.org/2822573004/ ) Reason for revert: Extra checks meant for short-term experiment only. Didn't catch anything, and we're getting close to new branch. BUG=710994 Review-Url: https://codereview.chromium.org/2887103003 Cr-Commit-Position: refs/heads/master@{#472497}

#2 id:20001 of https://codereview.chromium.org/2891513002/ ) Reason for revert: Broke CFI buildbots: https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20CF https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT Need build file fixes to make is_cfi imply use_lld. Original issue's description: > build: Remove build system support for gold plugin. > > R=thakis@chromium.org > TBR=mseaborn@chromium.org > BUG=607968 > > Review-Url: https://codereview.chromium.org/2891513002 > Cr-Commit-Position: refs/heads/master@{#472258} > Committed: https://chromium.googlesource.com/chromium/src/+/5d98fe2426808ddc4c9526a49ce63db2ace279c2 TBR=thakis@chromium.org,mseaborn@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=607968 Review-Url: https://codereview.chromium.org/2892643002 Cr-Commit-Position: refs/heads/master@{#472516}

…20001 of https://codereview.chromium.org/2886293002/ ) Reason for revert: Breaks compile on ChromiumOS x86-generic due to unused-but-set variable saw_focus_key Original issue's description: > Remove WINDOW_TYPE_V1_PANEL AppWindow type > > Changes: > Currently, panel window is only used as Chrome OS's audio player, which is WINDOW_TYPE_PANEL. WINDOW_TYPE_V1_PANEL is not a AppWindow type in use any more. Remove it in code base. > > BUG=691099 > TEST=covered by tests > > Review-Url: https://codereview.chromium.org/2886293002 > Cr-Commit-Position: refs/heads/master@{#472661} > Committed: https://chromium.googlesource.com/chromium/src/+/0775f98187d5d895b15b46212f55d30956aa946e TBR=benwells@chromium.org,oshima@chromium.org,warx@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691099 Review-Url: https://codereview.chromium.org/2891043002 Cr-Commit-Position: refs/heads/master@{#472740}

…#2 id:20001 of https://codereview.chromium.org/2891683002/ ) Reason for revert: Changes to jpeg_decode_accelerator_unittest.cc don't compile in build target "jpeg_decode_accelerator_unittest". Original issue's description: > Remove ScopedVector from all other codes in media/ > > base::ScopedVector is deprecated, see bug. > > BUG=554289, 588249 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2891683002 > Cr-Commit-Position: refs/heads/master@{#472700} > Committed: https://chromium.googlesource.com/chromium/src/+/60c246a6e0e6e0423d8b183c6143f9ce3e18b091 TBR=xhwang@chromium.org,alokp@chromium.org,bbudge@chromium.org,xiaofeng.zhang@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=554289, 588249 Review-Url: https://codereview.chromium.org/2893953002 Cr-Commit-Position: refs/heads/master@{#472818}

Added more logging in cleanup pass and used Open() instead of Create() as it appears some of the errors are on Create() in flaky tests so it's possible the previous code would fail to Create() and then skip the cleanup per !Valid(). BUG=721245 TBR=jam@chromium.org Review-Url: https://codereview.chromium.org/2894583003 . Cr-Commit-Position: refs/heads/master@{#472819}

…udioEncoder (patchset #2 id:20001 of https://codereview.chromium.org/2881713002/ ) Reason for revert: Suspected of causing content_unittests MediaRecorderHandlerTest.EncodeAudioFrames/2 to fail on Windows: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/60080 Original issue's description: > Reland Replace AudioFifo with a deque of AudioBus in ATR::AudioEncoder > > Link to original CL: https://codereview.chromium.org/2854363002/ > > Original CL description: > This CL uses a std::deque<std::unique_ptr<media::AudioBus>> instead > of an AudioFifo, to avoid copying data needlessly. > > The original CL was reverted due to failures in the build cycles as shown on: > https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzY3OGM3NGNmM2UxN2FhZWY5NTYyZWUxM2RmOGM4MDNlMWQwMTRmYzYM > > The failure was caused as uninitialized memory was being read. > > This reland CL zeroes out all channels of incoming audio bus if the deque is empty. > > BUG=None > > Review-Url: https://codereview.chromium.org/2881713002 > Cr-Commit-Position: refs/heads/master@{#472836} > Committed: https://chromium.googlesource.com/chromium/src/+/8e3f09678fd2199649fdfde1bb9cc0ec55240309 TBR=mcasas@chromium.org,miu@chromium.org,c.padhi@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.chromium.org/2888043007 Cr-Commit-Position: refs/heads/master@{#472906}

…inerImpl. (patchset #2 id:20001 of https://codereview.chromium.org/2886113002/ ) Reason for revert: Causes leak failure in editing/selection/selection-plugin-clear-crash.html. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/4790 (and locally, I get crashes in debug) Original issue's description: > Introduce WebPluginContainerBase to abstract WebPluginContainerImpl. > > Many classes in web/ take a dependancy on WebPluginContainerImpl, in some cases > this dependency is cyclic. In order to break this dependency we introduce a new > temporary abstraction WebPluginContainerBase, that derives from PlugingView, > WebPluginContainer and ContextClient. > > Classes that were taking a dependency on WebPluginContainerImpl now take a > dependency on WebPluginContainerBase. In cases where there we methods that > were only defined in WebPluginContainerImpl we make them pure virtual in > WebPluginContainerBase and override them in WebPluginContainerImpl. > > As WebPluginContainerImpl is garbage collected, we move this to > WebPluginContainerBase and define a virtual trace method. > > The intention is for this abstraction to be temporary, once we move all of the > dependencies into core/ we can remove it. > > I put the new class in core/exported as it derives from WebPluginContainer. > > > BUG=712963 > > Review-Url: https://codereview.chromium.org/2886113002 > Cr-Commit-Position: refs/heads/master@{#472810} > Committed: https://chromium.googlesource.com/chromium/src/+/303acce5cc18d95d46342bd089e06957841bc21b TBR=tkent@chromium.org,dcheng@chromium.org,sashab@chromium.org,slangley@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=712963 Review-Url: https://codereview.chromium.org/2888283004 Cr-Commit-Position: refs/heads/master@{#472915}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update build GN files / targets fully. #2

Update build GN files / targets fully. #2

vade commented Jan 30, 2017 •

edited

Loading

Update build GN files / targets fully. #2

Update build GN files / targets fully. #2

Comments

vade commented Jan 30, 2017 • edited Loading

vade commented Jan 30, 2017 •

edited

Loading