Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Searches not showing some relevent substrings #13

Open
ChildishGiant opened this issue Jun 9, 2024 · 1 comment
Open

🐞 Searches not showing some relevent substrings #13

ChildishGiant opened this issue Jun 9, 2024 · 1 comment

Comments

@ChildishGiant
Copy link

Describe the bug

image
Searching for imp doesn't show smiling_imp, probably due to imp existing. It does show mending_heart for some reason? 🤔

Reproduction

No response

Operating System

Manjaro 24

Emoji Mart version

0.2.4

Additional context

No response

@vemonet
Copy link
Owner

vemonet commented Aug 22, 2024

Thanks for the notice @ChildishGiant , this is because the search is not done on the emoji :id: but on the main label and some keywords

You can see the exact metadata for all emojis in english here: https://github.com/vemonet/EmojiMart/blob/main/src/data/en.json#L2939

  • Mending heart is using the keyword "improving"
  • Devil face is not using "imp" in the label and keywords

Ideally we should fix the upstream npm package: https://github.com/missive/emoji-mart so that it also use the :id: when doing the search (must be relatively easy)

I have already noted a few improvements that could be done to the search in this other issue: #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants