Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor vtoycli compilation script for enhanced clarity and modularity #2671

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsvenbla
Copy link

@tsvenbla tsvenbla commented Dec 7, 2023

  • Introduce a compile_vtoycli function to centralize the compilation logic for different architectures. This function accepts the compiler, library, output binary name, and extra flags as arguments.
  • Simplify removal of old binaries by consolidating rm commands into a single line.
  • Utilize the compile_vtoycli function to compile the vtoycli tool for x64, ia32, aarch64, and mips64el architectures.
  • Improve the check for successful compilation by verifying the existence of all expected binaries before proceeding to strip and move them.
  • Streamline the stripping and moving of binaries to their respective directories, enhancing the script's readability and maintainability.

Note:
I did not test this refactored code. Merge only after testing.

- Introduce a `compile_vtoycli` function to centralize the compilation logic for different architectures. This function accepts the compiler, library, output binary name, and extra flags as arguments.
- Simplify removal of old binaries by consolidating `rm` commands into a single line.
- Utilize the `compile_vtoycli` function to compile the `vtoycli` tool for x64, ia32, aarch64, and mips64el architectures.
- Improve the check for successful compilation by verifying the existence of all expected binaries before proceeding to strip and move them.
- Streamline the stripping and moving of binaries to their respective directories, enhancing the script's readability and maintainability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant