Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net decomposition: tuning and polishing #2516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

duck2
Copy link
Contributor

@duck2 duck2 commented Mar 23, 2024

Paper version of the net decomposing router. Major fixes are:

  1. Don't count pruned sinks towards high fanout case's chan_nodes_added
  2. Add a minimum bin size for the HF case to prevent minuscule bins when flat routing is enabled
  3. Incrementally update the PartitionTree instead of rebuilding on every iteration

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Mar 23, 2024
@duck2 duck2 force-pushed the partition_subtree branch 2 times, most recently from 7fcea0f to 4e9b58f Compare October 25, 2024 20:24
@duck2 duck2 marked this pull request as ready for review October 25, 2024 20:24
vpr/src/route/DecompNetlistRouter.h Show resolved Hide resolved
vpr/src/route/DecompNetlistRouter.h Show resolved Hide resolved
vpr/src/route/DecompNetlistRouter.tpp Outdated Show resolved Hide resolved
vpr/src/route/DecompNetlistRouter.tpp Show resolved Hide resolved
vpr/src/route/DecompNetlistRouter.tpp Outdated Show resolved Hide resolved
vpr/src/route/partition_tree.cpp Show resolved Hide resolved
vpr/src/route/partition_tree.cpp Show resolved Hide resolved
vpr/src/route/partition_tree.cpp Outdated Show resolved Hide resolved
vpr/src/route/sink_sampling.h Outdated Show resolved Hide resolved
vpr/src/route/spatial_route_tree_lookup.cpp Show resolved Hide resolved
@vaughnbetz
Copy link
Contributor

vaughnbetz commented Oct 25, 2024

Also add tests for the net decomposing router. One small circuit in strong, so it is checked all the time. Should have a run on bigger designs too in one of the nightly tests.

@vaughnbetz
Copy link
Contributor

Should try to land this before the code format PR if at all possible. Fahri thinks this can be landed in 2 weeks (mid-November) but that it shouldn't block a code format PR.

@duck2 duck2 force-pushed the partition_subtree branch 2 times, most recently from 69304fe to f67a224 Compare November 14, 2024 17:41
@vaughnb-cerebras
Copy link

@duck2 : can you add the QoR data as it becomes available? We'll need: net-decomposing router, serial router, master router anyway (your call if you also want to check the baseline router to be safe)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants