[Sys] Increased Read Buffers to Reduce Total Syscalls #2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
lang-cpp
vaughnbetz
reviewed
Nov 18, 2024
This change was originally proposed by @heshpdx See PR verilog-to-routing#2772 By increasing the read buffer, the number of syscalls can be reduced since more of the large files are read per call.
AlexandreSinger
force-pushed
the
feature-increase-read-buffer
branch
from
890c014
to
79caa34
Compare
|
@vaughnbetz Because these are across different libraries, I could not cleanly allow them to share the same DEFINE (without a terrible header file, which I did not like). Instead, they would need a define per library. I agree with your points above. I have changed the default to 1MB and removed the logic in the CMake from directly changing the values (since we are setting them to 1MB anyways). Let me know what you think. |
|
LGTM. Will merge as soon as CI passes. |
|
1 MB will be good for the next 20 years. 😄 |
|
And in 21 years, it will be Alex's problem :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was originally proposed by @heshpdx
See PR #2772
By increasing the read buffer, the number of syscalls can be reduced since more of the large files are read per call.