-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keywords sent over eventbus and sockjs bridge lose namespace #124
Comments
We lose the namespace for symbols when we encode to json for the eventbus. If you need a higher-fidelity format, I recommend encoding the data as edn or transit to a string before sending it, then decoding it on the other side. I don't think it would be difficult to write a few wrapper functions to handle that for you. Will that solve your use-case? |
Encoding it manually will work as a short-term workaround. I can understand stripping symbol namespaces, but a keyword namespace, because of its use in preventing key collisions, feels like something that should be preserved. |
I took a closer look at this, and I think you're right - we should write namespaced keywords out to json as |
Implemented in 96eaa98. I've released 1.0.4-SNAPSHOT - can you give that a try and see if it works for you? You'll need to update |
That fixed it for me. Thank you. |
Great, thanks for the feedback. I'll try to get a release out early next week. |
This was released as part of 1.0.4. |
My server process responds to an event on the Vert.x eventbus, sent using js client library and sockjs bridge, with a hash-map whose keys are namespaced keywords.
When I access the results, in the reply function on the js client, the keywords arrive with the namespace set to
null
.The namespace is also lost on keywords sent from the js client.
The text was updated successfully, but these errors were encountered: