Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClojureVerticleFactory should serialize verticle start() #134

Closed
tobias opened this issue Mar 27, 2015 · 3 comments
Closed

ClojureVerticleFactory should serialize verticle start() #134

tobias opened this issue Mar 27, 2015 · 3 comments
Milestone

Comments

@tobias
Copy link
Contributor

tobias commented Mar 27, 2015

If clojure.jar is on the classpath, verticles don't get isolated runtimes, which isn't really a problem in itself, but does cause issues with namespaces being accessed before they are completely loaded. Serializing start() should prevent that.

@tobias tobias added this to the 1.0.5 milestone Mar 27, 2015
tobias added a commit that referenced this issue Mar 27, 2015
@tobias
Copy link
Contributor Author

tobias commented Mar 31, 2015

I now realize this is also an issue even when you don't have a clojure.jar on the classpath, since multiple instances of the same verticle will share the same runtime, and may collide loading namespaces there as well.

@prio
Copy link

prio commented Apr 1, 2015

Hi Toby. Have been testing this since last Friday and my application is behaving much better, no longer seeing the errors I was previously seeing when restarting.

@tobias
Copy link
Contributor Author

tobias commented Apr 1, 2015

@prio - thanks for the feedback! This has been released in v1.0.5 if you want to move past the SNAPSHOT.

@tobias tobias closed this as completed Apr 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants