Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQTT Server should let the clients send the commands before CONNACK #121

Open
paul-lysak opened this issue Mar 18, 2019 · 1 comment
Open

MQTT Server should let the clients send the commands before CONNACK #121

paul-lysak opened this issue Mar 18, 2019 · 1 comment

Comments

@paul-lysak
Copy link
Contributor

According to the MQTT Spec section 3.1.4 (http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/errata01/os/mqtt-v3.1.1-errata01-os-complete.html#_Toc442180845):
"Clients are allowed to send further Control Packets immediately after sending a CONNECT Packet; Clients need not wait for a CONNACK Packet to arrive from the Server."
Eclipse IoT-Testware for MQTT (https://iottestware.readthedocs.io/en/master/mqtt_test_suite.html) follows this way, and some tests send control packets right after the CONNECT, before CONNACK arrives.

But current implementation of vertx-mqtt doesn't support it - for example, MqttServerConnection.handleSubscribe (as well as other handlers for control packets) calls MqttServerConnection.checkConnected, and checkConnected
closes the socket if it is called prior to MqttEndpointImpl.accept(boolean).
@vietj
Copy link
Contributor

vietj commented Mar 18, 2019

@ppatierno can we schedule this as a feature request ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vietj @paul-lysak