Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce logging levels for several client log messages #95

Open
sfitts opened this issue May 24, 2018 · 2 comments
Open

Reduce logging levels for several client log messages #95

sfitts opened this issue May 24, 2018 · 2 comments

Comments

@sfitts
Copy link

sfitts commented May 24, 2018

Version -- 3.5.1

The logging levels for some things are pretty verbose. For example, line 174 of MqttClientImpl uses an "error" log level for an exception that will be given to the connection handler (so the caller will get the error and can decide if it wants to scream about it -- we don't).

In the same place successful connections print an "INFO" log (at line 179).

In general I'd prefer if Vert.x logging was DEBUG and below except in extreme circumstances.

@vietj
Copy link
Contributor

vietj commented May 25, 2018

I agree with you.

one practice I found is to log only the message of these errors (some are expected) but log the full trace if debug is enabled

@vietj
Copy link
Contributor

vietj commented Jul 10, 2018

@ppatierno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants