Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some opinions on the new profile viz #668

Open
wey-gu opened this issue Nov 14, 2023 · 1 comment
Open

some opinions on the new profile viz #668

wey-gu opened this issue Nov 14, 2023 · 1 comment
Labels
type/feature req Type: feature request

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Nov 14, 2023

Amazing work @mizy !!! some small opinions request for comments:

  1. The font could be revisited for block details, we may avoid Serif fonts.
Screenshot 2023-11-14 at 16 22 08
  1. Consider making it focus on the start plan node like this ? This will let user know they could click plan node to get more info
Screenshot 2023-11-14 at 16 23 42
  1. Consider add a pie chart for all nodes? or show time ratio (like 51%) after the execution plan node? so that user could see which one is the most costly one
@mizy
Copy link
Contributor

mizy commented Nov 14, 2023

Amazing work @mizy !!! some small opinions request for comments:

  1. The font could be revisited for block details, we may avoid Serif fonts.
Screenshot 2023-11-14 at 16 22 08 2. Consider making it focus on the start plan node like this ? This will let user know they could click plan node to get more info Screenshot 2023-11-14 at 16 23 42 3. Consider add a pie chart for all nodes? or show time ratio (like 51%) after the execution plan node? so that user could see which one is the most costly one
  1. ok, it's a bug
  2. we can active one random node of the start-nodes
  3. @yyh0808 i think display time ratio maybe good

@QingZ11 QingZ11 added the type/feature req Type: feature request label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature req Type: feature request
Projects
None yet
Development

No branches or pull requests

3 participants