Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Repository selection step changes install-id even before DPU has been setup #300

Open
avikalpg opened this issue Apr 10, 2024 · 0 comments
Labels
bugs Something isn't working tech debt Issue is part of tech debt

Comments

@avikalpg
Copy link
Member

Repo selection steps in the cases of GitHub individual installation and Bitbucket project installation currently communicate to the DPU the set of selected repositories by updating the install_id (and we also update the repo_config table at the same time, deleting all the rows for repositories that are not selected.

This can create problems when a user already has setup once and comes back to the setup page, but only completes repository selection without re-running the docker. For example:

  1. The setup API from the browser extension will not give accurate output
  2. No webhook would be set up for the new repositories selected, so Vibinex will not work for them. Plus, since the install_id has been removed from the old repositories, so even if the webhook exists, it will not trigger the DPU to process the pull request.
  3. Even manual triggers will stop working for the old repositories, for which the install_id has been deleted.
@avikalpg avikalpg added bugs Something isn't working tech debt Issue is part of tech debt labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugs Something isn't working tech debt Issue is part of tech debt
Projects
None yet
Development

No branches or pull requests

1 participant