Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/api: add info to 'trigger' method #101

Open
Kogoruhn opened this issue Feb 8, 2019 · 1 comment
Open

docs/api: add info to 'trigger' method #101

Kogoruhn opened this issue Feb 8, 2019 · 1 comment

Comments

@Kogoruhn
Copy link

Kogoruhn commented Feb 8, 2019

Hi! No component in docs api contain a notice about trigger('event'), that without parameter { bubbles: true } events doesnt bubbling. Please, add this.

@gkatsev
Copy link
Member

gkatsev commented Feb 11, 2019

Are you talking about in this section? https://docs.videojs.com/module-events.html#trigger

If so, the docs for it is generated in the main repo (https://github.com/videojs/video.js/blob/master/src/js/utils/events.js#L388-L404), would you be able to make a PR? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants