Merge pull request #93 from vil02/asserts_in_spiced

style: remove `assert`s from `spiced`

puzzle_generator/configurators/simple/spiced.py

@@ -44,6 +44,7 @@ def get_encrypt(self):
 
     def get_needed_objects(self):
         return csc.OBJECTS + [
+            sse.must_be_nonempty,
             sse.get_decrypt,
         ]
 

puzzle_generator/encryption_algorithms/simple/spiced.py

@@ -11,14 +11,19 @@
 )
 
 
+def must_be_nonempty(in_list: typing.List[bytes]) -> None:
+    if not in_list:
+        raise ValueError("in_list must be nonempty")
+
+
 def get_encrypt(
     proc_spices: typing.List[bytes],
     signature_spices: typing.List[bytes],
     scrypt_params,
     signature_params,
 ) -> typing.Callable[[bytes, bytes], bytes]:
-    assert proc_spices  # nosec B101
-    assert signature_spices  # nosec B101
+    must_be_nonempty(proc_spices)
+    must_be_nonempty(signature_spices)
 
     def _encrypt(in_bytes: bytes, in_pass: bytes) -> bytes:
         signature_spice = secrets.choice(signature_spices)
@@ -39,8 +44,8 @@ def get_decrypt(
     scrypt_params,
     signature_params,
 ) -> typing.Callable[[bytes, bytes], bytes | None]:
-    assert proc_spices  # nosec B101
-    assert signature_spices  # nosec B101
+    must_be_nonempty(proc_spices)
+    must_be_nonempty(signature_spices)
 
     def _decrypt(in_bytes: bytes, in_pass: bytes) -> bytes | None:
         for proc_spice in proc_spices:

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "puzzle-generator"
-version = "0.12.2"
+version = "0.12.3"
 description = "Generates python code representing a puzzle"
 authors = ["piotr.idzik <vil02_puzzle_generator@10g.pl>"]
 readme = "./puzzle_generator/README.md"

tests/encryption_algorithms/test_spiced.py

@@ -0,0 +1,8 @@
+import pytest
+
+import puzzle_generator.encryption_algorithms.simple.spiced as ess
+
+
+def test_must_be_nonempty_raises() -> None:
+    with pytest.raises(ValueError, match="in_list must be nonempty"):
+        ess.must_be_nonempty([])