Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Companies display messed up #50

Open
kaustubhgupta opened this issue Jun 29, 2021 · 7 comments
Open

[BUG] Companies display messed up #50

kaustubhgupta opened this issue Jun 29, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@kaustubhgupta
Copy link
Contributor

Describe the bug
I have made my email id private and therefore the stats card shows the companies I am part of. If the company count is more, then it displays them over the contribution graph, making it look messy.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://github-profile-summary-cards.vercel.app/demo.html'
  2. Type my profile: "kaustubhgupta"
  3. See the companies point.

Expected behavior
In case the companies are more, it should be stacked vertically below the companies icon

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 91.0.4472.114 (Official Build) (64-bit)
@vn7n24fzkq
Copy link
Owner

Hi, thanks for your report.
A vertical companies list probably make the bottom margin looks odd.
How about we only show the first company?

@kaustubhgupta
Copy link
Contributor Author

If possible, a toggle can be added for displaying all the companies. The default setting can be set to display only one company. In this way, the user can decide whether they want to display all of them or only one.

I will prefer to display all of them.

@vn7n24fzkq
Copy link
Owner

vn7n24fzkq commented Jul 1, 2021

Sorry for the late reply.

I prefer display all company too, but the original usage way of this tool is the GitHub Actions way.

Add a company toggle means we also need to add a parameter to GitHub Actions way.

I thinks we could display company vertically and auto increase the height of card, then we can handle with any number of company.

And I am too busy to deal this feature in July .

If you are interested, you can also make a pull request, and I will merge it if possible.

@kaustubhgupta
Copy link
Contributor Author

I could have made the PR but I don't program in JavaScript and code in Python.

@vn7n24fzkq
Copy link
Owner

Okay.
@kaustubhgupta Thanks for your report again.
I will do this when I'm free.

@vn7n24fzkq vn7n24fzkq added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jul 29, 2021
@stale
Copy link

stale bot commented Sep 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 27, 2021
@vn7n24fzkq vn7n24fzkq removed the wontfix This will not be worked on label Sep 29, 2021
@stale
Copy link

stale bot commented Nov 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 28, 2021
@vn7n24fzkq vn7n24fzkq removed the wontfix This will not be worked on label Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants