Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add TCN models + DAS datasets #630

Open
5 of 8 tasks
NickleDave opened this issue Feb 24, 2023 · 3 comments · Fixed by #670
Open
5 of 8 tasks

ENH: Add TCN models + DAS datasets #630

NickleDave opened this issue Feb 24, 2023 · 3 comments · Fixed by #670
Assignees
Labels
ENH: enhancement enhancement; new feature or request Models Issue related to models

Comments

@NickleDave
Copy link
Collaborator

NickleDave commented Feb 24, 2023

@NickleDave
Copy link
Collaborator Author

Re-opening this because we haven't added datasets yet

@NickleDave
Copy link
Collaborator Author

Also because after discussion with @yardencsGitHub it's clear that I have made a mistake in my implementation and need to do further work on this

Leaving the initial implementation in this branch:
https://github.com/vocalpy/vak/tree/implement-DAS-model

Will remove from the main branch for now

Next step will be to compute segment error rate as we do using the original model in keras to understand what I am doing wrong

@NickleDave NickleDave changed the title ENH: Add DAS models + datasets ENH: Add TCN models + DAS datasets Jan 22, 2024
@NickleDave
Copy link
Collaborator Author

NickleDave commented Jan 22, 2024

I think we can still add a TCN model, e.g. from here
https://github.com/vocalpy/Nicholson-Cohen-SfN-2023-poster
We just shouldn't claim to perfectly replicate DAS

@NickleDave NickleDave added the Models Issue related to models label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENH: enhancement enhancement; new feature or request Models Issue related to models
Projects
None yet
1 participant