Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fzf support #1

Open
Anachron opened this issue Jan 21, 2023 · 1 comment
Open

fzf support #1

Anachron opened this issue Jan 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Anachron
Copy link

It would be great if dialog were optional and fzf would be accepted as well.

@classabbyamp classabbyamp added the enhancement New feature or request label Jan 21, 2023
@classabbyamp
Copy link
Member

classabbyamp commented Jan 21, 2023

  1. dialog is already used in the installer, and one of the main targets for this is being part of the liveusb/installer
  2. fzf seems to have a different paradigm for interaction than dialog, so it would probably not work well to support both
  3. (less of a concern now but) fzf has some issues on big-endian systems
  4. I don't know much about using fzf, but i'd maybe accept a PR to switch to it at a later date (like, after release), if it could work well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants