Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken for ruby 1.8.7 #297

Closed
matonb opened this issue Apr 21, 2016 · 4 comments
Closed

Broken for ruby 1.8.7 #297

matonb opened this issue Apr 21, 2016 · 4 comments

Comments

@matonb
Copy link

matonb commented Apr 21, 2016

This change breaks compatibility with ruby 1.8.7

https://github.com/voxpupuli/puppet-mcollective/blob/master/lib/puppet/parser/functions/mco_array_to_string.rb#L3

The older syntax
Puppet::Parser::Functions.newfunction(:mco_array_to_string, :type -> :rvalue) do |args|

Still works with ruby 2.2.4, only rubocop is complaining.

Puppet 4 ships wit ruby 2.1.8 is testing against 2.2.4 required at the moment ?

@bastelfreak
Copy link
Member

Hi,
we dropped ruby1.8.7 support a while back. Currently we test against 1.9-2.3. Please use one of the older releases if you still need 1.8.7 support or upgrade your Ruby Version.

@matonb
Copy link
Author

matonb commented Apr 21, 2016

So you're not supporting Enterprise Linux 6 ?

@alexjfisher
Copy link
Member

So you don't support RHEL6 anymore even though it's in the metadata.json?

Puppet 4 on EL6 comes with a later ruby, but this module isn't puppet 4 compatible.

Would reverting to the old hash style for that function and adding a rubocop control comment not be ok?

@bastelfreak
Copy link
Member

After checking the code: the last release should still support ruby1.8.7, just our master branch doesn't. We've got several open issues here and we are trying to resolve them, this includes adding Puppet4 support.


We're aware of the fact that RHEL still has support from RedHat. But that system is sooo old, most of the stuff there as no upstream support anymore, for example their shipped Ruby version. Testing and developing against that old thing is really painful for us. Many of our development tools don't support 1.8.7 anymore. Also there aren't any security patches from the Ruby developers anymore. We decided to drop 1.8.7 support for all modules in the voxpupuli namespace. Mostly everything except for RHEL ships a newer ruby version and in 99% of the cases you can use the new Puppet AIO packages which ship their own embedded Ruby or you can build them by yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants