Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify deploy preview always builds the main spec, even when the PR changes a different spec in the monorepo #2285

Closed
cookiecrook opened this issue Jul 17, 2024 · 4 comments

Comments

@cookiecrook
Copy link
Contributor

Netlify deploy preview always builds the main spec, even when the PR changes a different spec in the monorepo

I noticed in Core-AAM PR #2284 that the deploy preview built the main ARIA spec. I expect we'd prefer to see the Core-AAM spec in this case, since that's what changed in the PR.

@cookiecrook cookiecrook added the editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo label Jul 17, 2024
@pkra
Copy link
Member

pkra commented Jul 17, 2024

All specs are built in every netlify preview - we just haven't worked out adding links yet (#2242 is tracking that).

Just extend the path, e.g., https://deploy-preview-2284--wai-aria.netlify.app/core-aam/.

@spectranaut
Copy link
Contributor

closing as duplicate of #2242

@daniel-montalvo
Copy link
Contributor

@cookiecrook and others.

Currently you can still get to the relevant preview by adding /spec-shortname/ to the end of the base URI.

You could have https://deploy-preview-2284--wai-aria.netlify.app/core-aam/ and that'll take you to the ore-AAM version of that PR.

I'm still figuring out a way to customize Netlify PR comments to explicitly list all spec preview URIs.

@rahimabdi
Copy link
Contributor

You can also check the spec preview using the "Checks" tab within the PR (it shows up in the "Netlify" section-> "Pages changed - wai-aria").

@pkra pkra added duplicate and removed editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo labels Jul 19, 2024
@pkra pkra closed this as completed Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants