Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make top-level main navigation items not clickable when there's no link associated with them #944

Closed
trubach opened this issue Sep 25, 2023 · 1 comment · Fixed by #945
Closed
Assignees
Labels
bug Something isn't working

Comments

@trubach
Copy link
Contributor

trubach commented Sep 25, 2023

Currently, if you make a top-level menu item that shows up in the main navigation menu but put in no link using <nolink>, that item will appear to be a valid link, and if you click on it, it will take you back to the current page. This behavior is confusing to the user.

What we're proposing should happen instead is that if the top-level main navigation item is set to <nolink> then that item should show the sub-menu on hover, but the item itself isn't clickable and doesn't show the pointer icon.

@trubach trubach added the bug Something isn't working label Sep 25, 2023
@trubach trubach self-assigned this Sep 25, 2023
trubach added a commit that referenced this issue Sep 25, 2023
@trubach trubach linked a pull request Sep 25, 2023 that will close this issue
trubach added a commit that referenced this issue Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant