Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] build: use Rslib to build packages #1407

Closed
wants to merge 1 commit into from
Closed

[WIP] build: use Rslib to build packages #1407

wants to merge 1 commit into from

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Sep 11, 2024

Summary

This PR is far from complete, it's just here to document the migration process and identify potential issues (see the @rslib/core is even linked for debugging :P ). When this PR is ready for review, Rspress will be built by Rslib.

So far, just by looking at the output, the package can't be built is marked by "--wip--" and the reason is attached.

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@fi3ework fi3ework marked this pull request as draft September 11, 2024 08:33
@fi3ework fi3ework changed the title build: use Rslib to build packages [WIP] build: use Rslib to build packages Sep 11, 2024
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit e6b0c6c
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66fa6ae4885a760008a44604
😎 Deploy Preview https://deploy-preview-1407--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 90 (🟢 up 2 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@fi3ework
Copy link
Member Author

Will split into more separated PRs.

@fi3ework fi3ework closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant