Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): Overview component cannot be used when using base #1642

Merged
merged 2 commits into from
Dec 6, 2024
Merged

fix(theme): Overview component cannot be used when using base #1642

merged 2 commits into from
Dec 6, 2024

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Dec 5, 2024 •
edited
Loading

Summary

empty Overview when using base together
image

Related Issue

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Dec 5, 2024 •
edited
Loading

✅ Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit d546ce9
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/67527c01dac743000872e7dd
😎 Deploy Preview https://deploy-preview-1642--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 88 (🟢 up 5 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter requested a review from Timeless0911 December 6, 2024 04:13
Timeless0911
Timeless0911 approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@Timeless0911 Timeless0911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should review and reorg the functions using in Node and runtime in the future.

@Timeless0911 Timeless0911 enabled auto-merge (squash) December 6, 2024 04:23
@Timeless0911 Timeless0911 merged commit 0a140dc into main Dec 6, 2024
7 checks passed
@Timeless0911 Timeless0911 deleted the fix/overview-withbase branch December 6, 2024 04:31
@chenjiahan chenjiahan mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees
No one assigned
Labels
change: fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SoonIter @Timeless0911