Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will bukkit wrapper switch to remapped-mojang in the future #4170

Open
shou692199 opened this issue Nov 28, 2024 · 1 comment
Open

Will bukkit wrapper switch to remapped-mojang in the future #4170

shou692199 opened this issue Nov 28, 2024 · 1 comment
Labels
Feature Request Requests for Features

Comments

@shou692199
Copy link

I think it's a great idea to use obfuscation mapping in bukkit wrapper, so that developers can port to new version easily without confusion.

As in #4164 (comment) , there were misused NMS calls that can be prevented with human readable code.

@shou692199 shou692199 added the Feature Request Requests for Features label Nov 28, 2024
@jacob1
Copy link

jacob1 commented Dec 4, 2024

Agreed. Mistakes are inevitable in the current system. Minor updates are now content updates, meaning most will have breaking changes. Often hard to notice. I think I got them all, but without a comment saying what they were supposed to be it's hard to trust even the previous version's mapping as correct.

1.21.4 also has changes you'd never catch, because it compiles (almost) fine with 1.21.3's mappings but it changed other functions behind the scenes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Requests for Features
Projects
None yet
Development

No branches or pull requests

2 participants