Skins not affecting dark theme?

[JVimes]

The skins don't seem to be affecting dark theme, for me. Is that expected, or am I using it wrong?
Thanks!

[welpo]

Hello!

Last I checked, skins do affect both themes, as long as they are properly defined. Are you using a built-in skin, or a custom one? If the latter, can you share it?

If it's a custom one, my guess is it's not following this format for the dark theme variables:

:root {
    --primary-color: #087e96;
}

[data-theme='dark'] {
    --primary-color: #91e0ee;
}

[JVimes]

It happens incognito on latest desktop Chrome (v128.0.6613.138), for me.
Skin affects light mode but not dark mode.

Here's a repro case:

1. Clone https://github.com/welpo/tabi.git
2. Set skin = "red" in config.toml
3. Run zola serve --open at the root of clone.

[welpo]

I think I figured it out.

If you manually change the theme when it loads on light mode, does it work as intended?

That is: if your OS is set to light theme, tabi should load properly with both modes. If your OS is set to dark theme, then the issue occurs.

[JVimes]

Ah, yes. With OS in light mode, Tabi skin color works in both light/dark page themes.

[welpo]

Alright, I can reproduce.

I believe the issue appeared here #357.

Working on a fix~

Thanks for reporting this!

[JVimes]

Thank you so much! I'm delighted to discover Tabi 🙂

[welpo]

:) Thank you!