Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_forgit_ignore_clean is unused #407

Open
5 of 10 tasks
sandr01d opened this issue Nov 12, 2024 · 1 comment
Open
5 of 10 tasks

_forgit_ignore_clean is unused #407

sandr01d opened this issue Nov 12, 2024 · 1 comment

Comments

@sandr01d
Copy link
Collaborator

Check list

  • I have read through the README
  • I have the latest version of forgit
  • I have searched through the existing issues

Environment info

  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:
  • Shell
    • bash
    • zsh
    • fish

Problem / Steps to reproduce

The forgit_ignore_clean() function is currently unused. It is also not possible to invoke the function by executing forgit::ignore::clean because ignore_clean is not in public_commands. I'm not fully sure what the intended behavior is here. Should ignore_clean get added to public_commands or was it intended as a private function and should be dropped? Let me know and I'll send a PR.

@carlfriedrich
Copy link
Collaborator

@sandr01d Good find, never noticed this. Blaming this function shows that it has been there under different names before we moved the implementation to git-forgit and even in the very first commit. Seems like it has never been called anywhere, though.

@wfxr Can you tell us more perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants