Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gd does not use the screen space properly #411

Open
5 of 10 tasks
dtinhvo opened this issue Nov 22, 2024 · 1 comment
Open
5 of 10 tasks

gd does not use the screen space properly #411

dtinhvo opened this issue Nov 22, 2024 · 1 comment

Comments

@dtinhvo
Copy link

dtinhvo commented Nov 22, 2024

Check list

  • I have read through the README
  • I have the latest version of forgit
  • I have searched through the existing issues

Environment info

  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:
  • Shell
    • bash
    • zsh
    • fish

Problem / Steps to reproduce

  • Install forgit
  • use delta for pager
  • Use gd
    Issues:
  • fzf diffed file results does not start from the current command line location, but from the bottom
    image
  • In the above example, gd with a commit selected (HEAD^) disables preview keybinding (?)
  • Hitting enter does not use the whole screen for the pager, cropped horizontally
    image

Further information:
I am using wezterm over ssh domain. Without ssh, the disabled preview keybinding. I also suspect this can be a less pager problem (that my delta pager uses)

@sandr01d
Copy link
Collaborator

fzf diffed file results does not start from the current command line location, but from the bottom

This is just how fzf works. You can move this to the top of your terminal, e.g. by setting FORGIT_FZF_DEFAULT_OPTS="--padding=0,0,49%" but AFAIK there is no option in fzf to start from the current command line location.

In the above example, gd with a commit selected (HEAD^) disables preview keybinding (?)

Could you please explain what exactly you mean with this? I can toggle the preview with ?, which is the intended behavior, see

https://github.com/wfxr/forgit/blob/7a40a11e795f42c851eefbb2fd39419383c66ccd/bin/git-forgit#L34C1-L34C26

Hitting enter does not use the whole screen for the pager, cropped horizontally

This is an issue with how the side-by-side diff is implemented in delta. This has already been raised in #121 and you should be able to work around it with #121 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants