Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

produce logs in json format #8

Open
yzh44yzh opened this issue Apr 1, 2024 · 6 comments
Open

produce logs in json format #8

yzh44yzh opened this issue Apr 1, 2024 · 6 comments

Comments

@yzh44yzh
Copy link
Contributor

yzh44yzh commented Apr 1, 2024

@dziaineka @webchemist what do you think about changing logs to json format?
@dziaineka
Copy link
Contributor

@yzh44yzh I like the idea

@seriyps
Copy link
Member

seriyps commented Apr 2, 2024

By "json format" you mean "structured logs"? i.e. passing a map as 1st argument to logger:info? If so, then it's a quite good idea.

@yzh44yzh
Copy link
Contributor Author

yzh44yzh commented Apr 2, 2024

@seriyps exactly

@yzh44yzh
Copy link
Contributor Author

yzh44yzh commented Apr 2, 2024

However, it's like breaking API, this could harm projects which use this library.

@dziaineka
Copy link
Contributor

However, it's like breaking API, this could harm projects which use this library.

4.0.0 here we go 🙂

@yzh44yzh
Copy link
Contributor Author

yzh44yzh commented Apr 2, 2024

ok then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seriyps @yzh44yzh @dziaineka