-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
following usage instructions results in error #1
Comments
Hi Josh. PhantomJS as a dependency is certainly tricky; I'll have to look into some better docs on getting it installed and running. If I remember correctly I had to do some manual work to get the correct version of https://www.npmjs.com/package/phantomjs-prebuilt for my operating system. As for production, I run this in heroku using this buildpack to satisfy the phantomjs dependency: https://github.com/stomita/heroku-buildpack-phantomjs Have you managed to work around this problem yet? |
No - just started playing around with it. I don't have it live yet. Do you run it along side your app that uses it or do you have a separate app in heroku just for this? |
In production I run it as a standalone app; it is used to compile CSS for a few different apps. |
Ok. Got this running on heroku. And I have my rails app wired up with RailsCriticalCssServer. if I look in the logs of the critical-css-server I see POST requests being made to it that correspond with me refreshing my rails app. So, that's great. However, they're all status=202, which I think is this line? https://github.com/wheeyls/critical-css-server/blob/master/src/app.js#L33 I've been refreshing for a few minutes now - any ideas what i've missed? How long should it take to process a single page/file ? Thanks! |
One note, I commented out auth_token in the RailsCriticalCssServer config since I wasn't sure what kind of 'auth' that referred to on the node side. I suppose that's fine because it's getting to the 202 line above and not bonking on some 401 auth required. |
@josh-m-sharpe yeah the critical-css-server doesn't have any auth options by default; when I use this in production I actually route it through an extra middleware that looks for the auth token. Have you checked the logs on heroku with |
Hi @josh-m-sharpe, curious if you ever got this up and running? |
I can't seem to get this running locally - errors below. Is it possible the installation/usage sections are out of date?
More broadly - how are you hosting this for production? On heroku maybe? A section in the README about how to set that up would be much appreciated.
Thanks!
The text was updated successfully, but these errors were encountered: