Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add an approach to build and commit images of flows #50

Open
shahankhatch opened this issue Nov 1, 2021 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@shahankhatch
Copy link
Contributor

Feature Description

Currently, we have a build mechanism for the flows; however, this requires a stakeholder to clone and build this locally to view the images. This issue proposes a practice to build images of flows and include them in the repo as part of the documentation.

The simplest approach is to manually update flow images.
A more automated approach is to build images automatically as part of a build script and a pre-commit hook can verify that the images are built when the flow is updated. Automating image building as part of the pre-commit is beyond the scope of this proposal as it can change the set of files being committed.

Additional Information

@bitparadigm
Copy link
Contributor

bitparadigm commented Dec 17, 2021

@shahankhatch Seems like this should be closed as it was done in other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants