Failure to convert V3 wxs file to V4 with unclear error messages

[MarkStega]

I decided to try preview 0 and started by copying my product.wxs file to product4.wxs

I then tried to run “wix convert Product4.wxs” and received the following output:

C:\Solutions\OHI\Optimiser\WiX.2012>wix convert Product4.wxs
C:\Solutions\OHI\Optimiser\WiX.2012\Product4.wxs : error WIX0005: This file contains an XML declaration on the first line. (DeclarationPresent)
C:\Solutions\OHI\Optimiser\WiX.2012\Product4.wxs(59) : error WIX0009: The namespace 'http://schemas.microsoft.com/wix/2006/wi' is out of date.  It must be 'http://wixtoolset.org/schemas/v4/wxs'. (XmlnsValueWrong)
C:\Solutions\OHI\Optimiser\WiX.2012\Product4.wxs(60) : error WIX0009: The namespace 'http://schemas.microsoft.com/wix/UtilExtension' is out of date.  It must be 'http://wixtoolset.org/schemas/v4/wxs/util'. (XmlnsValueWrong)
C:\Solutions\OHI\Optimiser\WiX.2012\Product4.wxs(61) : error WIX0023: Using '*' for the Product Id attribute is unnecessary. Remove the attribute to remove the redundancy. (AutoGuidUnnecessary)
C:\Solutions\OHI\Optimiser\WiX.2012\Product4.wxs(61) : error WIX0030: The Product and Package elements have been renamed and reorganized for simplicity. (ProductAndPackageRenamed)
C:\Solutions\OHI\Optimiser\WiX.2012\Product4.wxs(80) : error WIX0058: The TARGETDIR directory should not longer be explicitly defined. Remove the Directory element with Id attribute 'TARGETDIR'. (TargetDirDeprecated)
C:\Solutions\OHI\Optimiser\WiX.2012\Product4.wxs(0) : error WIX0059: Standard directories such as 'ProgramFilesFolder' should no longer be defined using the Directory element. Use the StandardDirectory element instead. (DefiningStandardDirectoryDeprecated)
C:\Solutions\OHI\Optimiser\WiX.2012\Product4.wxs(0) : error WIX0046: The namespace 'http://wixtoolset.org/schemas/v4/wxs/util' is not used. Remove unused namespaces. (RemoveUnusedNamespaces)

Here are the first 80 lines or so of Product4.wxs (I added annotations to show line numbers in the form of “[nn]”) :

<!--  24FEB2016 Mark Stega -->
<!--            Initial implementation -->
<!--            Based upon https://developingsoftware.com/wix-toolset-install-windows-service/ -->
<!--            and http://stackoverflow.com/questions/9116870/wix-how-to-install-multiple-windows-services-with-one-executable -->

<!-- The name of each service, its description, and corresponding installer -->

<?define ServiceName1 = "Optimi$er.CommunicationService" ?>
<?define ServiceDescriptor1 = "Send and receives email, fax, and text messages" ?>
<?define ServiceTargetFileName1 = $(var.CommunicationService.TargetFileName)?>
<?define ServiceQualifiedTargetFileName1 = "$(var.CommunicationService.TargetDir)$(var.CommunicationService.TargetFileName)"?>

<?define ServiceName2 = "Optimi$er.FileCleanupService" ?>
<?define ServiceDescriptor2 = "Cleanup of old files" ?>
<?define ServiceTargetFileName2 = $(var.FileCleanupService.TargetFileName)?>
<?define ServiceQualifiedTargetFileName2 = "$(var.FileCleanupService.TargetDir)$(var.FileCleanupService.TargetFileName)"?>

<?define ServiceName3 = "Optimi$er.LCIFileInterfaceService" ?>
<?define ServiceDescriptor3 = "Receives and processes incoming LCI interface files" ?>
<?define ServiceTargetFileName3 = $(var.LCIFileInterfaceService.TargetFileName)?>
<?define ServiceQualifiedTargetFileName3 = "$(var.LCIFileInterfaceService.TargetDir)$(var.LCIFileInterfaceService.TargetFileName)"?>

<?define ServiceName4 = "Optimi$er.PATFileInterfaceService" ?>
<?define ServiceDescriptor4 = "Receives and processes incoming PAT interface files" ?>
<?define ServiceTargetFileName4 = $(var.PATFileInterfaceService.TargetFileName)?>
<?define ServiceQualifiedTargetFileName4 = "$(var.PATFileInterfaceService.TargetDir)$(var.PATFileInterfaceService.TargetFileName)"?>

<?define ServiceName5 = "Optimi$er.PersistentStorageService" ?>
<?define ServiceDescriptor5 = "Receives CQRS messages and maintains datastore" ?>
<?define ServiceTargetFileName5 = $(var.PersistentStorageService.TargetFileName)?>
<?define ServiceQualifiedTargetFileName5 = "$(var.PersistentStorageService.TargetDir)$(var.PersistentStorageService.TargetFileName)"?>

<?define ServiceName6 = "Optimi$er.ReportService" ?>
<?define ServiceDescriptor6 = "Creates reports on demand" ?>
<?define ServiceTargetFileName6 = $(var.ReportService.TargetFileName)?>
<?define ServiceQualifiedTargetFileName6 = "$(var.ReportService.TargetDir)$(var.ReportService.TargetFileName)"?>

<?define ServiceName7 = "Optimi$er.RIAOFileInterfaceService" ?>
<?define ServiceDescriptor7 = "Receives and processes incoming RIAO interface files" ?>
<?define ServiceTargetFileName7 = $(var.RIAOFileInterfaceService.TargetFileName)?>
<?define ServiceQualifiedTargetFileName7 = "$(var.RIAOFileInterfaceService.TargetDir)$(var.RIAOFileInterfaceService.TargetFileName)"?>

<?define ServiceName8 = "Optimi$er.SystemMonitorService" ?>
<?define ServiceDescriptor8 = "Starts Optimi$er services and monitors performance" ?>
<?define ServiceTargetFileName8 = $(var.SystemMonitorService.TargetFileName)?>
<?define ServiceQualifiedTargetFileName8 = "$(var.SystemMonitorService.TargetDir)$(var.SystemMonitorService.TargetFileName)"?>

<!-- The manufacturer, for setup package publisher and folder info -->
<?define Manufacturer = "Optimium Health" ?>

<!-- UpgradeCode must be unique and not changed once the first version of the program is installed. -->
<?define UpgradeCode = "{490D7555-CBE9-4632-AE28-2D80B54673D2}" ?>

<!-- The version, as driven by SystemMonitorService.Exe -->
<?define Version = $(var.ProductVersion) ?>

[57] <Wix xmlns=http://wixtoolset.org/schemas/v4/wxs>
[58]   <Package Name="Optimi$er" Manufacturer="$(var.Manufacturer)" UpgradeCode="$(var.UpgradeCode)" Version="$(var.Version)" Language="1033" InstallerVersion="300"><SummaryInformation Description="Version: $(var.Version)" />
[59]
[60]    <!-- We are creating a single msi with the cab file embedded -->
[61]    <Media Id="1" Cabinet="Optimiser.cab" EmbedCab="yes" />

    <!-- Allow upgrades and prevent downgrades -->
    <MajorUpgrade DowngradeErrorMessage="A later version of [ProductName] is already installed. Setup will now exit." />

    <!-- Define the directory structure -->
    

    <!-- The files inside this DirectoryRef are linked to the service directory via APPLICATIONROOTDIRECTORY -->
    <!-- Add files to your installer package -->

    <DirectoryRef Id="APPLICATIONROOTDIRECTORY1">
      <Component Id="ComponentId1" Guid="{19CD5363-7065-4CB4-A863-D4CC6B82362B}">

        <File Id="ServiceTargetFileName1" Name="$(var.ServiceTargetFileName1)" Source="$(var.ServiceQualifiedTargetFileName1)" />

        <!-- Remove the log file on uninstall
        <RemoveFile Id="LogId1" Name="*.txt" On="uninstall" /> -->

[80]        <!-- Tell WiX to install the Service -->
        <ServiceInstall Id="ServiceInstaller1" Type="ownProcess" Name="$(var.ServiceName1)" DisplayName="$(var.ServiceName1)" Description="$(var.ServiceDescriptor1)" Start="demand" Account="LocalSystem" ErrorControl="normal" />

        <ServiceControl Id="StartControl1" Stop="both" Remove="both" Name="$(var.ServiceName1)" Wait="yes" />

      </Component>

So I don’t understand the error messages & would have thought that the convert process would be updating the wxs file.

[robmen]

The messages are telling you what needed to be fixed and wix convert fixed the issues (unless you specify -n). So hopefully, the file should be v4 .wxs when you are done (and it seems to be).

[rseanhall]

Those undefined preprocessor variables are coming from MSBuild project references. MSBuild support is not available in preview 0.

[robmen]

As @rseanhall said, see #5170 for the build failures.

You could look through the issues and see if anyone has made a suggestion to enhance the wix convert messages when fixing. It'd be low priority but if you wanted to take the work on, it'd probably be a thing to take in wix4... and an easy way to get started.

[MarkStega]

@rseanhall -- Thanks, It never even crossed my mind that these were MSBuild projects. It makes me want preview 1 even more!

@robmen -- I can't find a pertinent issue. If it is just me that finds error messages for elements that are being successfully converted I'd leave it alone. If you think it is generally useful I'd take the project on but would expect that I would have to pepper questions about which errors are really errors and which should be information and reworded.

[robmen]

I can see how the current wording could be confusing, that's why I think the issue has merit. Its value is far below all the other work for me to get done in v4 (for example, I'm eyebrows deep in MSBuild right now for -preview.1) but it is a pretty easy issue for someone to get started in wix4.

And, yeah, people that want to contribute the first time often have several questions. As long as you are clearly making an effort, we're happy to help field questions. Although, answers may take a bit to come if other work is taking priority. 😄

[MarkStega]

@robmen Issue #6681